Fix modules build of AVRAsmParser.cpp

[arichardson]

Summary

Without this change I get the following error:

lib/Target/AVR/AVRGenAsmMatcher.inc:1135:1: error: redundant #include of module 'LLVM_Utils.Support.Format' appears within namespace 'llvm' [-Wmodules-import-nested-redundant]

[arichardson]

ping?

[dylanmckay]

Hey @arichardson, sorry for the delay, exam period!

This looks great. I remember building the LLVM tree recently, but I don't remember hitting this. I am unsure if I that was slightly before or slightly after you posted this patch on the 19th though.

The llvm-avr-linux buildbot running clang didn't seem to hit this either. Perhaps it's a GCC thing?

Regardless, AVRAsmParser is a private implementation detail of createAVRAsmParser and so moving it into an anonymous namespace makes sense.

Thanks for the patch @arichardson

lib/Target/AVR/AsmParser/AVRAsmParser.cpp

 #include "llvm/Support/Debug.h"
 #include "llvm/Support/MathExtras.h"
 #include "llvm/Support/TargetRegistry.h"
 
 #include <sstream>
 
 #define DEBUG_TYPE "avr-asm-parser"
 
-namespace llvm {
+using namespace llvm;
 
+namespace {
 /// Parses AVR assembly from a stream.
 class AVRAsmParser : public MCTargetAsmParser {
   const MCSubtargetInfo &STI;
   MCAsmParser &Parser;
   const MCRegisterInfo *MRI;
   const std::string GENERATE_STUBS = "gs";
 
 #define GET_ASSEMBLER_HEADER
case k_Memri: {
       O << "Memri: \"" << getReg() << '+' << *getImm() << "\"";
       break;
     }
     }
     O << "\n";
   }
 };
 
+} // end anonymous namespace.
+
 // Auto-generated Match Functions
 
 /// Maps from the set of all register names to a register number.
 /// \note Generated by TableGen.
 static unsigned MatchRegisterName(StringRef Name);
 
 /// Maps from the set of all alternative registernames to a register number.
 /// \note Generated by TableGen.
if (isSubclass(Expected, MCK_DREGS)) {
       if (correspondingDREG != AVR::NoRegister) {
         Op.makeReg(correspondingDREG);
         return validateOperandClass(Op, Expected);
       }
     }
   }
   return Match_InvalidOperand;
 }
-
-} // end of namespace llvm