This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] X87 RFP setup code.
ClosedPublic

Authored by courbet on Oct 19 2018, 2:19 AM.

Details

Summary

This was lost during refactoring in rL342644.

Fix and simplify simplify value size handling: always go through a 80 bit value,
because the value can be 1 byte). Add unit tests.

Diff Detail

Event Timeline

courbet created this revision.Oct 19 2018, 2:19 AM
gchatelet accepted this revision.Oct 19 2018, 2:50 AM
gchatelet added inline comments.
tools/llvm-exegesis/lib/X86/Target.cpp
186

kF80Bytes so it makes more sense to use LD_F80m afterwards

unittests/tools/llvm-exegesis/X86/TargetTest.cpp
299

Can you add a comment for all non-80bits tests to explain why we put an 80bits value on the stack?

This revision is now accepted and ready to land.Oct 19 2018, 2:50 AM
courbet updated this revision to Diff 170174.Oct 19 2018, 2:58 AM
courbet marked 2 inline comments as done.

address comments

This revision was automatically updated to reflect the committed changes.