Fix generation of exported targets in build directory

[mcopik]

Summary

After a long investigation of my own CMake scripts, I found out that CMake is not able to link with Polly libraries because the exported targets file is not generated correctly in the build directory when CONFIG is not set.

The generated file lib/cmake/polly/PollyExports-all.cmake

set_target_properties(LLVMPolly PROPERTIES
              IMPORTED_LOCATION_ my_build_dir/lib/LLVMPolly.so)
set_target_properties(Polly PROPERTIES
              IMPORTED_LOCATION_ my_build_dir/lib/libPolly.a)

Please notice the additional underscore at the end of IMPORTED_LOCATION. The generation for install directory works correctly since the generator expression used there adds the underscore and config name only when it's defined. This patch simply adds this missing guard for cmake files generated in the build directory.

[Meinersbur]

I suggest to add @philip.pfaffe as a reviewer (who contributed these lines in D30495)

[philip.pfaffe]

The fix looks alright, but did you test it with CMAKE_BUILD_TYPE set though? It's hard to parse with the naked eye, but it looks like you're missing at least a $ there.

[mcopik]

In D53376#1270537, @philip.pfaffe wrote:

The fix looks alright, but did you test it with CMAKE_BUILD_TYPE set though? It's hard to parse with the naked eye, but it looks like you're missing at least a $ there.

I took this code directly from line 114 where it is defined for install target. But you were correct, this code is not correct. It's missing a $ in front of UPPER_CASE and it's missing a > in the end. Otherwise the main condition "print if config not empty" is not interpreted as a boolean generator expression. I fixed the patch and uploaded a new one.

That's the new output for CMAKE_BUILD_TYPE set to Release:

build directory:

set_target_properties(LLVMPolly PROPERTIES
              IMPORTED_LOCATION_RELEASE build_dir/lib/LLVMPolly.so)
set_target_properties(Polly PROPERTIES
              IMPORTED_LOCATION_RELEASE build_dir/lib/libPolly.a)

install directory:

set_target_properties(LLVMPolly PROPERTIES
        IMPORTED_LOCATION_RELEASE ${CMAKE_CURRENT_LIST_DIR}/../../LLVMPolly.so)
set_target_properties(Polly PROPERTIES
        IMPORTED_LOCATION_RELEASE ${CMAKE_CURRENT_LIST_DIR}/../../libPolly.a)

Before it was:

set_target_properties(LLVMPolly PROPERTIES
        IMPORTED_LOCATION_<UPPER_CASE:Release ${CMAKE_CURRENT_LIST_DIR}/../../LLVMPolly.so)
set_target_properties(Polly PROPERTIES
        IMPORTED_LOCATION_<UPPER_CASE:Release ${CMAKE_CURRENT_LIST_DIR}/../../libPolly.a)

Names are generated correctly for an empty build type as well.

[philip.pfaffe]

LGTM, thanks!

[mcopik]

@philip.pfaffe could I ask to commit the patch on my behalf? I don't have write access to the repository.

[philip.pfaffe]

Commited!

polly/trunk/cmake/CMakeLists.txt

 set(POLLY_CONFIG_LIBRARY_DIRS "${POLLY_BINARY_DIR}/lib")
 
 # set locations for imported targets
 foreach(tgt IN LISTS POLLY_CONFIG_EXPORTED_TARGETS)
   get_target_property(tgt_type ${tgt} TYPE)
   if (NOT tgt_type STREQUAL "INTERFACE_LIBRARY")
     set(POLLY_EXPORTS
       "set_target_properties(${tgt} PROPERTIES
-              IMPORTED_LOCATION_$<UPPER_CASE:$<CONFIG>> $<TARGET_FILE:${tgt}>)
+              IMPORTED_LOCATION$<$<NOT:$<CONFIG:>>:_$<UPPER_CASE:$<CONFIG>>> $<TARGET_FILE:${tgt}>)
 ${POLLY_EXPORTS}")
   endif()
 endforeach(tgt)
 
 # PollyConfig holds the target definitions and general settings, PollyExports
 # the imported locations
 configure_file(
   ${CMAKE_CURRENT_SOURCE_DIR}/PollyConfig.cmake.in
foreach(tgt IN LISTS POLLY_CONFIG_EXPORTED_TARGETS)
   endif()
 
   set(tgt_path "${CMAKE_INSTALL_PREFIX}/${tgt_prefix}$<TARGET_FILE_NAME:${tgt}>")
   file(RELATIVE_PATH tgt_path ${POLLY_CONFIG_CMAKE_DIR} ${tgt_path})
 
   if (NOT tgt_type STREQUAL "INTERFACE_LIBRARY")
     set(POLLY_EXPORTS
 "set_target_properties(${tgt} PROPERTIES
-        IMPORTED_LOCATION$<$<NOT:$<CONFIG:>>:_<UPPER_CASE:$<CONFIG>> \${CMAKE_CURRENT_LIST_DIR}/${tgt_path})
+        IMPORTED_LOCATION$<$<NOT:$<CONFIG:>>:_$<UPPER_CASE:$<CONFIG>>> \${CMAKE_CURRENT_LIST_DIR}/${tgt_path})
 ${POLLY_EXPORTS}")
   endif()
 endforeach(tgt)
 
 configure_file(
   ${CMAKE_CURRENT_SOURCE_DIR}/PollyConfig.cmake.in
   ${CMAKE_CURRENT_BINARY_DIR}/CMakeFiles/PollyConfig.cmake
   @ONLY)