Page MenuHomePhabricator

[VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS.
ClosedPublic

Authored by vsapsai on Oct 12 2018, 4:39 PM.

Details

Summary

'ignore-non-existent-contents' stopped working after r342232 in a way
that the actual attribute value isn't used and it works as if it is
always true.

Common use case for VFS iteration is iterating through files in umbrella
directories for modules. Ability to detect if some VFS entries point to
non-existing files is nice but non-critical. Instead of adding back
support for 'ignore-non-existent-contents': false I am removing the
attribute, because such scenario isn't used widely enough and stricter
checks don't provide enough value to justify the maintenance.

rdar://problem/45176119

Event Timeline

vsapsai created this revision.Oct 12 2018, 4:39 PM
bruno accepted this revision.Oct 23 2018, 11:20 AM

LGTM.

This revision is now accepted and ready to land.Oct 23 2018, 11:20 AM
This revision was automatically updated to reflect the committed changes.

Thanks for the review.