This is an archive of the discontinued LLVM Phabricator instance.

[python] [tests] Remove cdb lookup failure test
ClosedPublic

Authored by mgorny on Oct 12 2018, 9:29 AM.

Details

Summary

Remove the test checking for compilation db lookup failure.
Since r342228, JSONCompilationDatabasePlugin infers compile commands for
missing files, therefore making the lookup always succeed.

Diff Detail

Repository
rL LLVM

Event Timeline

mgorny created this revision.Oct 12 2018, 9:29 AM
sammccall accepted this revision.Oct 12 2018, 9:41 AM

We could verify the fuzzy-matched results, but we have pretty good testing on the C++ side, so a smoke test here seems fine.

This revision is now accepted and ready to land.Oct 12 2018, 9:41 AM

Thanks for the review!

This revision was automatically updated to reflect the committed changes.