This is an archive of the discontinued LLVM Phabricator instance.

[python] [tests] Fix calling tests on Windows (hopefully)
ClosedPublic

Authored by mgorny on Oct 11 2018, 10:59 AM.

Download Raw Diff

Details

Reviewers

rnk
steveire
aaron.ballman

Commits

rGd50a4310dcee: [python] [tests] Fix calling tests on Windows
rC344288: [python] [tests] Fix calling tests on Windows
rL344288: [python] [tests] Fix calling tests on Windows

Summary

Fix passing arguments to the Python test command to use 'env' builtin CMake
command, in order to fix compatibility with Windows.

NB: I don't have a Windows environment to test it

Diff Detail

Repository: rL LLVM

Event Timeline

mgorny created this revision.Oct 11 2018, 10:59 AM

mgorny added reviewers: steveire, aaron.ballman.

mgorny retitled this revision from [python] [tests] Fix calling pytest on Windows (hopefully) to [python] [tests] Fix calling tests on Windows (hopefully).

mgorny edited the summary of this revision. (Show Details)

lgtm

The cmake builtin tools are pretty useful. =)

This revision was not accepted when it landed; it landed in state Needs Review.Oct 11 2018, 1:28 PM

Closed by commit rL344288: [python] [tests] Fix calling tests on Windows (authored by mgorny). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: llvm-commits. · View Herald TranscriptOct 11 2018, 1:28 PM

Revision Contents

Path

Size

cfe/

trunk/

bindings/

python/

tests/

CMakeLists.txt

4 lines

Diff 169292

cfe/trunk/bindings/python/tests/CMakeLists.txt

	# Test target to run Python test suite from main build.			# Test target to run Python test suite from main build.

	add_custom_target(check-clang-python			add_custom_target(check-clang-python
	COMMAND CLANG_LIBRARY_PATH=$<TARGET_FILE_DIR:libclang> ${PYTHON_EXECUTABLE} -m unittest discover			COMMAND ${CMAKE_COMMAND} -E env
				CLANG_LIBRARY_PATH=$<TARGET_FILE_DIR:libclang>
				${PYTHON_EXECUTABLE} -m unittest discover
	DEPENDS libclang			DEPENDS libclang
	WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/..)			WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/..)

	#set_property(GLOBAL APPEND PROPERTY LLVM_ADDITIONAL_TEST_TARGETS check-clang-python)			#set_property(GLOBAL APPEND PROPERTY LLVM_ADDITIONAL_TEST_TARGETS check-clang-python)