Page MenuHomePhabricator

[LLD] [MinGW] Expand comment for MinGW driver.

Authored by mstorsjo on Oct 9 2018, 10:43 AM.

Diff Detail


Event Timeline

ruiu created this revision.Oct 9 2018, 10:43 AM
ruiu updated this revision to Diff 168832.Oct 9 2018, 10:45 AM
  • fix typos
smeenai added inline comments.
10 ↗(On Diff #168832)

Should be either "consists of" or "comes with"

16 ↗(On Diff #168832)

differnet -> different

18 ↗(On Diff #168832)

translate -> translates

21 ↗(On Diff #168832)

calls lld/COFF driver -> calls the lld/COFF driver?

22 ↗(On Diff #168832)

run lld/COFF linker -> run the lld/COFF linker?

26 ↗(On Diff #168832)

implemented -> implements?

+1 to the rest of @smeenai's comments

26 ↗(On Diff #168832)

I don't see anything wrong with what's written here at the moment.

smeenai added inline comments.Oct 9 2018, 11:43 AM
26 ↗(On Diff #168832)

It sounds more natural in the present tense to me (it flows better from the previous part of the sentence), but yeah, it's fine either way.

@ruiu Do you have time to finish this one, there shouldn't be much to do?

mstorsjo commandeered this revision.Jan 4 2019, 2:27 PM
mstorsjo updated this revision to Diff 180324.
mstorsjo edited reviewers, added: ruiu; removed: mstorsjo.
mstorsjo retitled this revision from Expand comment for MinGW driver. to [LLD] [MinGW] Expand comment for MinGW driver..
mstorsjo added a reviewer: smeenai.

Corrected @smeenai's review comments.

ruiu accepted this revision.Jan 4 2019, 2:57 PM


Feel free to commit.

This revision is now accepted and ready to land.Jan 4 2019, 2:57 PM
This revision was automatically updated to reflect the committed changes.