This is an archive of the discontinued LLVM Phabricator instance.

[DwarfVerifier] Fixed -Wimplicit-fallthrough warning
ClosedPublic

Authored by xbolva00 on Oct 6 2018, 4:29 AM.

Reviewers

JDevlieghere
RKSimon

Commits

LGTM, Thx!

This revision is now accepted and ready to land.Oct 10 2018, 5:19 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

DebugInfo/

DWARF/

3 lines

Show First 20 Lines • Show All 502 Lines • ▼ Show 20 Lines	if (auto ReferencedDie = Die.getAttributeValueAsReferencedDie(Attr)) {
if (DieTag == DW_TAG_variable && RefTag == DW_TAG_member)		if (DieTag == DW_TAG_variable && RefTag == DW_TAG_member)
break;		break;
ReportError("DIE with tag " + TagString(DieTag) + " has " +		ReportError("DIE with tag " + TagString(DieTag) + " has " +
AttributeString(Attr) +		AttributeString(Attr) +
" that points to DIE with "		" that points to DIE with "
"incompatible tag " +		"incompatible tag " +
TagString(RefTag));		TagString(RefTag));
}		}
		break;
}		}
case DW_AT_type: {		case DW_AT_type: {
DWARFDie TypeDie = Die.getAttributeValueAsReferencedDie(DW_AT_type);		DWARFDie TypeDie = Die.getAttributeValueAsReferencedDie(DW_AT_type);
if (TypeDie && !isType(TypeDie.getTag())) {		if (TypeDie && !isType(TypeDie.getTag())) {
ReportError("DIE has " + AttributeString(Attr) +		ReportError("DIE has " + AttributeString(Attr) +
" with incompatible tag " + TagString(TypeDie.getTag()));		" with incompatible tag " + TagString(TypeDie.getTag()));
break;
}		}
		break;
}		}
default:		default:
break;		break;
}		}
return NumErrors;		return NumErrors;
}		}

unsigned DWARFVerifier::verifyDebugInfoForm(const DWARFDie &Die,		unsigned DWARFVerifier::verifyDebugInfoForm(const DWARFDie &Die,
▲ Show 20 Lines • Show All 911 Lines • Show Last 20 Lines