Page MenuHomePhabricator

[LLD] [docs] Mention some notable feature in the release notes
ClosedPublic

Authored by mstorsjo on Oct 4 2018, 2:31 PM.

Details

Summary

Trying to fill in releas notes as we go, even though there's a long way to go still until the branch point for 8.0.

LLD can now link clang.exe from object files compiled with GCC 7.x; with GCC 5.x one still needs D52602 though.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Oct 4 2018, 2:31 PM
smeenai added a subscriber: smeenai.Oct 4 2018, 2:35 PM
smeenai added inline comments.
docs/ReleaseNotes.rst
54–55 ↗(On Diff #168379)

I'm pretty certain link.exe supports branch islands. They even have optimization options related to that (see /opt:lbr): https://docs.microsoft.com/en-us/cpp/build/reference/opt-optimizations?view=vs-2017

mstorsjo added inline comments.Oct 4 2018, 2:37 PM
docs/ReleaseNotes.rst
54–55 ↗(On Diff #168379)

Oh, ok. I remember testing a pretty synthetic test case which it failed to link though, but maybe it does better with real-word code.

mstorsjo updated this revision to Diff 168383.Oct 4 2018, 2:38 PM

Corrected the statement about link.exe not supporting thunks for arm.

ruiu added a comment.Oct 4 2018, 2:40 PM

Maybe you should create a new section, "MinGW Improvements" for mingw improvements? I think most people who uses lld-link don't use lld-link for mingw, and I guess some of them even don't know what it is.

mstorsjo updated this revision to Diff 168440.Oct 5 2018, 12:50 AM

Added a separate section for MinGW related features.

emaste added a subscriber: emaste.Oct 5 2018, 6:09 AM

Looks good to me

ruiu accepted this revision.Oct 5 2018, 10:08 AM

LGTM

docs/ReleaseNotes.rst
46 ↗(On Diff #168440)

s/lld-link/lld/ for consistency with other notes.

This revision is now accepted and ready to land.Oct 5 2018, 10:08 AM
This revision was automatically updated to reflect the committed changes.