This is an archive of the discontinued LLVM Phabricator instance.

[X86] Standardize floating point assembly comments
ClosedPublic

Authored by RKSimon on Sep 30 2018, 4:57 AM.

Details

Summary

Consistently try to use APFloat::toString for floating point constant comments to get rid of differences between Constant / ConstantDataSequential values - it should help stop some of the linux-windows buildbot failures matching NaN/INF etc. as well.

Not sure if this is redundant if/when D37184 lands?

Diff Detail

Repository
rL LLVM

Event Timeline

RKSimon created this revision.Sep 30 2018, 4:57 AM
This revision is now accepted and ready to land.Oct 1 2018, 10:19 AM

If the output of llvm::write_double isn't consistent between Linux and Windows, we should probably fix that.

That said, this is still fine.

lib/Target/X86/X86MCInstLower.cpp
2105 ↗(On Diff #167641)

You could also check for isHalfTy(); I guess it's unlikely to be relevant on x86, though.

This revision was automatically updated to reflect the committed changes.