This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Start a new line for the next output if there are no symbols in the current symtab
ClosedPublic

Authored by asmith on Sep 27 2018, 12:51 PM.

Details

Summary

If there is no newline the "lldb" prompt could be on the wrong line. To reproduce the missing newline you can do 'image dump smytab' on any binary.

Previously

Symtab, file = D:\upstream\build\Debug\bin\clang-diff.exe, num_symbols = 0(lldb)

Now

Symtab, file = D:\upstream\build\Debug\bin\clang-diff.exe, num_symbols = 0
(lldb)

Diff Detail

Repository
rL LLVM

Event Timeline

asmith created this revision.Sep 27 2018, 12:51 PM

Couple of options:

  1. Can you give an example of before/after output?
  2. Is the size_t change related?
  3. Can you use -U999999 in the future when generating patches?

s/options/comments/

asmith edited the summary of this revision. (Show Details)Sep 30 2018, 2:53 PM
asmith updated this revision to Diff 167670.Sep 30 2018, 9:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 1 2018, 10:10 AM
This revision was automatically updated to reflect the committed changes.