Page MenuHomePhabricator

[lldb] Remove an assertion in RichManglingContext::GetBufferRef() hit when debugging a native x86 Windows process
ClosedPublic

Authored by asmith on Sep 27 2018, 12:46 PM.

Details

Summary

A RichManglingContext constructed with an invalid demangled name or with a demangled function name without any context will have an empty context. This triggers an assertion in RichManglingContext::GetBufferRef() when debugging a native Windows process on x86 when it shouldn't. Remove the assertion.

Diff Detail

Event Timeline

asmith created this revision.Sep 27 2018, 12:46 PM
zturner accepted this revision.Sep 27 2018, 4:08 PM

BTW, I wrote a demangler for Windows ABI that should be 100% complete modulo bugs and can generate an AST that RichManglingContext should use. So it would be interesting if someone decided to start using that to make this actually work.

This revision is now accepted and ready to land.Sep 27 2018, 4:08 PM
asmith closed this revision.Sep 27 2018, 7:35 PM