Page MenuHomePhabricator
Differential D52607

[llvm-exegesis] Fix PR39096.
ClosedPublic
Actions

Authored by courbet on Sep 27 2018, 5:23 AM.

Details

Reviewers
gchatelet
Commits
rG30183093abf2: [llvm-exegesis] Fix PR39096.
rL343208: [llvm-exegesis] Fix PR39096.
Summary

The key is now the resource name, not the resource id.

Diff Detail

Repository
rL LLVM

Event Timeline

courbet created this revision.Sep 27 2018, 5:23 AM
Herald added a subscriber: tschuett. · View Herald TranscriptSep 27 2018, 5:23 AM
Harbormaster completed remote builds in B23183: Diff 167292.Sep 27 2018, 5:23 AM
courbet updated this revision to Diff 167295.Sep 27 2018, 5:27 AM

Use NumMicroOps in analysis display for consistency with measurement keys.

Harbormaster completed remote builds in B23184: Diff 167295.Sep 27 2018, 5:30 AM
• bdb added a subscriber: • bdb.Sep 27 2018, 5:32 AM
gchatelet accepted this revision.Sep 27 2018, 6:23 AM

Is there any documentation to update as well?

This revision is now accepted and ready to land.Sep 27 2018, 6:23 AM
courbet added a comment.Sep 27 2018, 6:26 AM
In D52607#1247840, @gchatelet wrote:

Is there any documentation to update as well?

No, I've used latency as an example.

Closed by commit rL343208: [llvm-exegesis] Fix PR39096. (authored by courbet). · Explain WhySep 27 2018, 6:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
llvm/
trunk/
test/
tools/
llvm-exegesis/
X86/
28 lines
28 lines
tools/
llvm-exegesis/
lib/
53 lines

Diff 167306

View Options

llvm/trunk/test/tools/llvm-exegesis/X86/analysis-inconsistencies-uops-backwards.test

Loading...
View Options

llvm/trunk/test/tools/llvm-exegesis/X86/analysis-inconsistencies-uops.test

Loading...
View Options

llvm/trunk/tools/llvm-exegesis/lib/Analysis.cpp

Loading...