This is an archive of the discontinued LLVM Phabricator instance.

Split invocations in CodeGen/X86/cpus.ll among multiple tests. (NFC)
ClosedPublic

Authored by JDevlieghere on Sep 27 2018, 4:30 AM.

Details

Summary

On GreenDragon CodeGen/X86/cpus.ll is timing out on the bot with Asan & UBSan enabled. With the same configuration on my machine, the test passes but takes more than 3 minutes to do so. I could increase the timeout, but I believe it makes more sense to split up the test because it allows for more parallelization.

Diff Detail

Event Timeline

JDevlieghere created this revision.Sep 27 2018, 4:30 AM
JDevlieghere retitled this revision from [test] Split invocations in CodeGen/X86/cpus.ll among multiple tests. to Split invocations in CodeGen/X86/cpus.ll among multiple tests. (NFC).

Use .ll file extension not .test

llvm/test/CodeGen/X86/cpus-64.test
1 ↗(On Diff #167275)

Maybe call this file cpus-no-x86_64.ll ?

Use .ll file extension not .test

The new files are not LLVM assembly files, they only contain RUN lines for lit that use the original cpus.ll.

  • Rename file

Use .ll file extension not .test

The new files are not LLVM assembly files, they only contain RUN lines for lit that use the original cpus.ll.

TBH I'd just put the foo() placeholder function in each file and use the .ll convention - its not like theres anything critical about cpus.ll

  • Make the different tests standalone.
andreadb accepted this revision.Sep 27 2018, 9:50 AM
andreadb added a subscriber: andreadb.

LGTM. Thanks!

This revision is now accepted and ready to land.Sep 27 2018, 9:50 AM
This revision was automatically updated to reflect the committed changes.