This is an archive of the discontinued LLVM Phabricator instance.

[test] Use --sysroot instead of -B in print-multi-directory.c
ClosedPublic

Authored by mstorsjo on Sep 26 2018, 1:00 AM.

Details

Summary

This avoids finding a similar matching GCC installation outside of the test directory tree in the surrounding environment, which would make the test fail.

Diff Detail

Event Timeline

mstorsjo created this revision.Sep 26 2018, 1:00 AM

Hi Martin,

maybe just a NIT, use --sysroot= rather than just --sysroot for consistency with other tests.

Otherwise looks good to me, thanks (adding Jonathan as I'm not sure I can accept)

Ping @jroelofs or someone else willing to have a look

Hi Martin,

Actually I reread the developer policy,
(https://llvm.org/docs/DeveloperPolicy.html#id13). As I contributed this
code and take responsibility for it. It seems that I can approve this patch.

So it looks OK for me, sorry for the delay,

Cheers

Christian

This revision was not accepted when it landed; it landed in state Needs Review.Oct 3 2018, 11:25 AM
This revision was automatically updated to reflect the committed changes.