Page MenuHomePhabricator

[WPD] Fix incorrect devirtualization after indirect call promotion
ClosedPublic

Authored by tejohnson on Sep 25 2018, 12:30 PM.

Details

Summary

Add a dominance check to ensure that the possible devirtualizable
call is actually dominated by the type test/checked load intrinsic being
analyzed. With PGO, after indirect call promotion is performed during
the compile step, followed by inlining, we may have a type test in the
promoted and inlined sequence that allows an indirect call in that
sequence to be devirtualized. That indirect call (inserted by inlining
after promotion) will share the same vtable pointer as the fallback
indirect call that cannot be devirtualized.

Before this patch the code was incorrectly devirtualizing the fallback
indirect call.

See the new test and the example described there for more details.

Diff Detail

Repository
rL LLVM