This is an archive of the discontinued LLVM Phabricator instance.

Differential D52402

[CMake][Fuchsia] Use internal_linkage rather than always_inline for libc++
ClosedPublic

Authored by phosek on Sep 23 2018, 1:04 AM.

Details

Reviewers
mcgrathr
jakehehrlich
EricWF
Commits
rGb2de4b39be84: [CMake] Use internal_linkage rather than always_inline for libc++
rL342833: [CMake] Use internal_linkage rather than always_inline for libc++
rC342833: [CMake] Use internal_linkage rather than always_inline for libc++
Summary

This is a workaround for PR39053 which was uncovered by D50652 when
the default attribute has been changed from internal_linkage to
always_inline.

Diff Detail

Repository
rC Clang

Event Timeline

phosek created this revision.Sep 23 2018, 1:04 AM
Herald added a reviewer: EricWF. · View Herald TranscriptSep 23 2018, 1:04 AM
Herald added subscribers: cfe-commits, mgorny. · View Herald Transcript
mcgrathr accepted this revision.Sep 23 2018, 1:05 AM

lgtm as long as we revert when the underlying bugs are resovled

This revision is now accepted and ready to land.Sep 23 2018, 1:05 AM
Closed by commit rC342833: [CMake] Use internal_linkage rather than always_inline for libc++ (authored by phosek). · Explain WhySep 23 2018, 1:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cmake/
caches/
2 lines

Diff 166634

cmake/caches/Fuchsia-stage2.cmake

Show First 20 Lines • Show All 103 Lines • ▼ Show 20 Lines foreach(target x86_64;aarch64)
set(RUNTIMES_${target}-fuchsia_LIBCXXABI_USE_COMPILER_RT ON CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBCXXABI_USE_COMPILER_RT ON CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXXABI_ENABLE_STATIC_UNWINDER ON CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBCXXABI_ENABLE_STATIC_UNWINDER ON CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXXABI_INSTALL_STATIC_LIBRARY OFF CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBCXXABI_INSTALL_STATIC_LIBRARY OFF CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_SHARED_LIBRARY OFF CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_SHARED_LIBRARY OFF CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXX_USE_COMPILER_RT ON CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBCXX_USE_COMPILER_RT ON CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY OFF CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY OFF CACHE BOOL "")
# TODO: this is a workaround for PR39053 which was uncovered by D50652.
set(RUNTIMES_${target}-fuchsia_LIBCXX_HIDE_FROM_ABI_PER_TU_BY_DEFAULT ON CACHE BOOL "")
endforeach() endforeach()
set(LLVM_RUNTIME_SANITIZERS "Address" CACHE STRING "") set(LLVM_RUNTIME_SANITIZERS "Address" CACHE STRING "")
set(LLVM_RUNTIME_SANITIZER_Address_TARGETS "x86_64-fuchsia;aarch64-fuchsia" CACHE STRING "") set(LLVM_RUNTIME_SANITIZER_Address_TARGETS "x86_64-fuchsia;aarch64-fuchsia" CACHE STRING "")
endif() endif()
set(LLVM_BUILTIN_TARGETS "${BUILTIN_TARGETS}" CACHE STRING "") set(LLVM_BUILTIN_TARGETS "${BUILTIN_TARGETS}" CACHE STRING "")
set(LLVM_RUNTIME_TARGETS "${RUNTIME_TARGETS}" CACHE STRING "") set(LLVM_RUNTIME_TARGETS "${RUNTIME_TARGETS}" CACHE STRING "")
Show All 40 Lines