This is an archive of the discontinued LLVM Phabricator instance.

Ensure that variant part discriminator is read by MetadataLoader
ClosedPublic

Authored by tromey on Sep 20 2018, 10:14 PM.

Details

Summary

https://reviews.llvm.org/D42082 introduced variant parts to debug info
in LLVM. Subsequent work on the Rust compiler has found a bug in that
patch; namely, there is a path in MetadataLoader that fails to restore
the discriminator.

This patch fixes the bug.

Diff Detail

Repository
rL LLVM

Event Timeline

tromey created this revision.Sep 20 2018, 10:14 PM
JDevlieghere accepted this revision.Sep 20 2018, 11:45 PM

LGTM, Thanks!

This revision is now accepted and ready to land.Sep 20 2018, 11:45 PM

Could someone please land this for me? Thank you.

This revision was automatically updated to reflect the committed changes.