This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objcopy/llvm-strip]: handle --version
ClosedPublic

Authored by rupprecht on Sep 20 2018, 3:33 PM.

Details

Summary

Implement --version for objcopy and strip.

I think there are LLVM utilities that automatically handle this, but that doesn't seem to work with custom parsing since this binary handles both objcopy and strip, so it uses custom parsing.

This fixes PR38298

Diff Detail

Repository
rL LLVM

Event Timeline

rupprecht created this revision.Sep 20 2018, 3:33 PM

I've just had a look at LLD - it does smth similar, so to me this looks good. Pls, wait for Jake as well.

This revision is now accepted and ready to land.Sep 20 2018, 3:43 PM
jakehehrlich accepted this revision.Sep 20 2018, 4:56 PM

So I'm good with this BTW.

This revision was automatically updated to reflect the committed changes.