This is an archive of the discontinued LLVM Phabricator instance.

[GlobalDCE] AvailableExternal linkage is checked in isDiscardableIfUnused [NFC].
ClosedPublic

Authored by trentxintong on Sep 20 2018, 12:45 PM.

Details

Summary

AvailableExternal was not handled in isDiscardableIfUnused when isDiscardableIfUnused
was added in r158476. Till it was handled in r247044. This is a NFC.

Diff Detail

Event Timeline

trentxintong created this revision.Sep 20 2018, 12:45 PM

I think this is an NFC (no functional change) cleanup, right? It would be good to add that in the description - i.e. put "[NFC]" at the end of the summary first line.

Address @tejohnson comment by adding NFCs to commit msg and summary.

trentxintong retitled this revision from [GlobalDCE] AvailableExternal linkage is checked in isDiscardableIfUnused to [GlobalDCE] AvailableExternal linkage is checked in isDiscardableIfUnused [NFC]..Sep 20 2018, 1:13 PM
trentxintong edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sep 20 2018, 1:17 PM
This revision was automatically updated to reflect the committed changes.