Diff Detail
Event Timeline
Hi Johannes,
I just tried your test case without the actual change to Polly and it already passes. The reason is most likely that all these intrinsics are side effect free functions and can consequently already be handled by Polly.
I think adding this test case is still valuable, but I would suggest a couple of minor changes to minimize the test case:
- Call the function 'intrinsics' instead of jd
- Use just a single loop and a single array.
There is no value added by a second loop and a second array, it just adds more code to the test case.
- No need to call pow twice
We could possibly also remove the "intrinsics" comment (or explain that only more complex buildins such as memcpy need special handling).
Thanks,
Tobias
I will remove the last 3 lines from the test case, after that we need the patch. Or is it decided not to handle intrisics explicitly?
[Polly] Support for math/misc intrinsics
Changed test case to use the new functionality.
Hi Johannes,
I just looked back at this patch and it seems you are still proposing to handle intrinsics explicitly in the ScopDetection. There is a large number of target
specific intrinsics (e.g., test/CodeGen/X86/combine-avx2-intrinsics.ll), which do not affect memory and which we can currently be handled. What are your plans of handling those?
Cheers,
Tobias
Uh, sorry. I was looking at an older version of this patch. The latest version looks in fact fine. Please feel free to commit.
Cheers,
Tobias