This is an archive of the discontinued LLVM Phabricator instance.

Remove dead function user_cache_directory()
ClosedPublic

Authored by thakis on Sep 17 2018, 12:24 PM.

Details

Summary

It's been unused since it was added almost 3 years ago in https://reviews.llvm.org/D13801

Motivated by https://reviews.llvm.org/rL342002 since it removes one of the functions keeping a ref to SHGetKnownFolderPath.

Diff Detail

Event Timeline

thakis created this revision.Sep 17 2018, 12:24 PM
rnk accepted this revision.Sep 17 2018, 1:13 PM

Thanks! It's very likely we can use getenv("USERPROFILE") or the unicode equivalent to eliminate the remaining one. It's also pretty reasonable to just hardcode %USERPROFILE%/AppData/Local if we ever need this functionality.

This revision is now accepted and ready to land.Sep 17 2018, 1:13 PM
This revision was automatically updated to reflect the committed changes.