This is an archive of the discontinued LLVM Phabricator instance.

Thread safety analysis: Run more tests with capability attributes [NFC]
ClosedPublic

Authored by aaronpuchert on Sep 15 2018, 2:40 PM.

Details

Summary

We run the tests for -Wthread-safety-{negative,verbose} with the new
attributes as well as the old ones. Also put the macros in a header so
that we don't have to copy them all around.

The warn-thread-safety-parsing.cpp test checks for warnings depending on
the actual attribute name, so it can't undergo the same treatment.

Together with D49275 this should fix PR33754.

Diff Detail

Event Timeline

aaronpuchert created this revision.Sep 15 2018, 2:40 PM
aaron.ballman accepted this revision.Sep 17 2018, 7:57 AM

LGTM, with a minor formatting nit.

test/SemaCXX/thread-safety-annotations.h
29

Can you add another newline above this comment, to fit my sense of aesthetics? :-P

This revision is now accepted and ready to land.Sep 17 2018, 7:57 AM
aaronpuchert marked an inline comment as done.Sep 17 2018, 2:35 PM

Makes sense to me. Thanks for the review!

This revision was automatically updated to reflect the committed changes.