This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP][libomptarget] Set the frame pointer then test empty slot condition
ClosedPublic

Authored by gtbercea on Sep 14 2018, 1:43 PM.

Reviewers

Commits

Summary

NFC - just fixing a bug: the empty slot test was before the re-setting of the Stack pointer.

This revision is now accepted and ready to land.Sep 25 2018, 7:30 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

libomptarget/

deviceRTLs/

nvptx/

src/

6 lines

Show First 20 Lines • Show All 471 Lines • ▼ Show 20 Lines	if (getThreadId() % WARPSIZE == 0) {
unsigned WID = getWarpId();		unsigned WID = getWarpId();

// Current slot		// Current slot
__kmpc_data_sharing_slot *&SlotP = DataSharingState.SlotPtr[WID];		__kmpc_data_sharing_slot *&SlotP = DataSharingState.SlotPtr[WID];

// Pointer to next available stack.		// Pointer to next available stack.
void *&StackP = DataSharingState.StackPtr[WID];		void *&StackP = DataSharingState.StackPtr[WID];

		// Pop the frame.
		StackP = FrameStart;

// If the current slot is empty, we need to free the slot after the		// If the current slot is empty, we need to free the slot after the
// pop.		// pop.
bool SlotEmpty = (StackP == &SlotP->Data[0]);		bool SlotEmpty = (StackP == &SlotP->Data[0]);

// Pop the frame.
StackP = FrameStart;

if (SlotEmpty && SlotP->Prev) {		if (SlotEmpty && SlotP->Prev) {
// Before removing the slot we need to reset StackP.		// Before removing the slot we need to reset StackP.
StackP = SlotP->PrevSlotStackPtr;		StackP = SlotP->PrevSlotStackPtr;

// Remove the slot.		// Remove the slot.
SlotP = SlotP->Prev;		SlotP = SlotP->Prev;
SafeFree(SlotP->Next, "Free slot.");		SafeFree(SlotP->Next, "Free slot.");
SlotP->Next = 0;		SlotP->Next = 0;
Show All 34 Lines