Details
Details
Diff Detail
Diff Detail
Event Timeline
| lib/tsan/tests/rtl/tsan_test_util_linux.cc | ||
|---|---|---|
| 13 | Comment here should be adjusted. IIRC we have no immediate plans to rename the files to indicate they apply to more than just Linux.so a comment could alleviate confusion for someone looking at this code in the future. | |
Comment Actions
LGTM
| lib/tsan/tests/rtl/tsan_test_util_linux.cc | ||
|---|---|---|
| 273 | While you're here, replace this with CHECK_EQ(ErrCode, errno); (expected value is supposed to go first). | |
Comment here should be adjusted.
IIRC we have no immediate plans to rename the files to indicate they apply to more than just Linux.so a comment could alleviate confusion for someone looking at this code in the future.