This is an archive of the discontinued LLVM Phabricator instance.

Support building tsan_test_util_linux.cc on FreeBSD
ClosedPublic

Authored by kutuzov.viktor.84 on Sep 5 2014, 4:28 AM.

Diff Detail

Event Timeline

kutuzov.viktor.84 retitled this revision from to Support building tsan_test_util_linux.cc on FreeBSD.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added reviewers: kcc, samsonov.
kutuzov.viktor.84 added subscribers: Unknown Object (MLST), emaste.
emaste added inline comments.Sep 5 2014, 5:52 AM
lib/tsan/tests/rtl/tsan_test_util_linux.cc
13

Comment here should be adjusted.

IIRC we have no immediate plans to rename the files to indicate they apply to more than just Linux.so a comment could alleviate confusion for someone looking at this code in the future.

samsonov accepted this revision.Sep 5 2014, 1:20 PM
samsonov edited edge metadata.

LGTM

lib/tsan/tests/rtl/tsan_test_util_linux.cc
273

While you're here, replace this with

CHECK_EQ(ErrCode, errno);

(expected value is supposed to go first).

This revision is now accepted and ready to land.Sep 5 2014, 1:20 PM
Diffusion closed this revision.Sep 6 2014, 1:08 AM
Diffusion updated this revision to Diff 13360.

Closed by commit rL217309 (authored by vkutuzov).