Page MenuHomePhabricator

[ToolChains] Linux.cpp: Use the same style across all all multi-arch includes. NFC.

Authored by kristina on Sep 14 2018, 6:21 AM.


Group Reviewers
Restricted Project

Currently it seems like a mess in terms of where newlines are used. Cleaning it up so all of them use newlines and are aligned and moving the default switch case to the top. Making a differential to see if anyone has objections to the style used.

Diff Detail

rC Clang

Event Timeline

kristina created this revision.Sep 14 2018, 6:21 AM
kristina added a reviewer: Restricted Project.Sep 14 2018, 6:21 AM
lebedev.ri added inline comments.

This *might* be what clang-format produces.

Yeah but what about the rest of them, most are completely on their own line, some no newlines, mipsel64 was split across two lines while others weren't, and switch is meant to have default as the topmost case IIRC. I mean I'm if you don't think it's more readable that way I'll abandon it. Though IMHO reading wise it's much easier to read as a list down with separators than as a mix of various newline/no-newline styles.

I don't have an opinion on the style per se, but please use clang-format. If it doesn't produce the formatting you want, then change the code so it does. (e.g. adding a trailing , at the end of an init-list will force one-per-line).

kristina abandoned this revision.Sep 15 2018, 6:48 PM