build: add libedit to include paths

[tatyana-krasnukha]

Summary

Without that build of Host, Core and Interpreter with custom libedit fails.

[davide]

How exactly are you building (i.e. what triggers this error)?

[tatyana-krasnukha]

Everything that includes Host/Editline.h (Host/Editline.cpp, Core/IOHandler.cpp, ...). Build fails with "fatal error: histedit.h: No such file or directory"

[tatyana-krasnukha]

TBC, I pass libedit_INCLUDE_DIRS and libedit_LIBRARIES manually to CMake.

[compnerd]

Can you use target_include_directories instead and do this only on lldbHost instead please? That restricts the inclusion to just that target, which would help prevent accidental inclusion of the headers. That is the change should be to source/Host/CMakeLists.txt.

[tatyana-krasnukha]

Unfortunately, doing this only on lldbHost is not enough, because CMake doesn't propagate include directories to dependent projects. I added these lines to every project that includes "Editline.h".

[compnerd]

It definitely shouldn't be PUBLIC, PRIVATE makes sense for this inclusion. Is there a library that pulls in the dependency (that is, do the other libraries need it due to lldbHost? If so, just adding it as INTERFACE on that library should be sufficient).

[tatyana-krasnukha]

LLDB's static libraries link each other as INTERFACE, that's why CMake doesn't propagate lldbHost's include directories to lldbCore and lldbInterpreter.
For lldbHost itself, I had to use PUBLIC, because its sources require includes libedit headers and unittests inherit this path too.

[compnerd]

LGTM, thanks!

lldb/trunk/source/Core/CMakeLists.txt

LINK_COMPONENTS
     BinaryFormat
     Support
     Demangle
   )
 
 # Needed to properly resolve references in a debug build.
 # TODO: Remove once we have better layering
 set_target_properties(lldbCore PROPERTIES LINK_INTERFACE_MULTIPLICITY 4)
+
+if (NOT LLDB_DISABLE_LIBEDIT)
+  target_include_directories(lldbCore PRIVATE ${libedit_INCLUDE_DIRS})
+endif()

lldb/trunk/source/Host/CMakeLists.txt

LINK_LIBS
     lldbUtility
     ${EXTRA_LIBS}
     ${LLDBObjCLibs}
 
   LINK_COMPONENTS
     Object
     Support
   )
+
+if (NOT LLDB_DISABLE_LIBEDIT)
+  target_include_directories(lldbHost PUBLIC ${libedit_INCLUDE_DIRS})
+endif()

lldb/trunk/source/Interpreter/CMakeLists.txt

LINK_LIBS
     lldbDataFormatters
     lldbHost
     lldbTarget
     lldbUtility
 
   LINK_COMPONENTS
     Support
   )
+
+if (NOT LLDB_DISABLE_LIBEDIT)
+  target_include_directories(lldbInterpreter PRIVATE ${libedit_INCLUDE_DIRS})
+endif()
 No newline at end of file