This is an archive of the discontinued LLVM Phabricator instance.

Add a basic test for 'memory region'

Authored by teemperor on Sep 11 2018, 7:16 AM.



The 'memory region' command is at the moment not tested at all by our test suite.
This patch just adds a basic test that at least provides some basic testing.

Diff Detail

Event Timeline

teemperor created this revision.Sep 11 2018, 7:16 AM
davide requested changes to this revision.Sep 11 2018, 7:31 AM
davide added a subscriber: davide.

I thought Vedant added an harness utility to test memory a bit ago. Have you looked into whether that's extensible for your purposes, Raphael?

This revision now requires changes to proceed.Sep 11 2018, 7:31 AM
teemperor added a subscriber: vsk.Sep 11 2018, 7:39 AM

@davide Maybe git is failing me, but I can only find D47508 but that doesn't seem related. Let's ping @vsk

Yeah, that's the revision I had in mind. Can't you extend lldb-test to do what you need?

vsk added a comment.Sep 11 2018, 11:48 AM

I think it'd be useful to test the driver output specifically. The kind of testing lldb-test facilitates might not be a good fit here (too low-level).

vsk added a comment.Sep 11 2018, 11:49 AM

This LGTM. Davide?

davide accepted this revision.Sep 11 2018, 1:09 PM

Yeah, sure :)

This revision is now accepted and ready to land.Sep 11 2018, 1:09 PM
This revision was automatically updated to reflect the committed changes.