Add a basic test for 'memory region'

[teemperor]

Summary

The 'memory region' command is at the moment not tested at all by our test suite.
This patch just adds a basic test that at least provides some basic testing.

[davide]

I thought Vedant added an harness utility to test memory a bit ago. Have you looked into whether that's extensible for your purposes, Raphael?

[teemperor]

@davide Maybe git is failing me, but I can only find D47508 but that doesn't seem related. Let's ping @vsk

[davide]

Yeah, that's the revision I had in mind. Can't you extend lldb-test to do what you need?

[vsk]

I think it'd be useful to test the driver output specifically. The kind of testing lldb-test facilitates might not be a good fit here (too low-level).

[vsk]

This LGTM. Davide?

[davide]

Yeah, sure :)

packages/Python/lldbsuite/test/functionalities/memory-region/Makefile

+LEVEL = ../../make
+
+CXX_SOURCES := main.cpp
+
+include $(LEVEL)/Makefile.rules
+
+clean::
+  rm -rf $(wildcard *.o *.d *.dSYM)

packages/Python/lldbsuite/test/functionalities/memory-region/TestMemoryRegion.py

+"""
+Test the 'memory region' command.
+"""
+
+from __future__ import print_function
+
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class MemoryCommandRegion(TestBase):
+
+    mydir = TestBase.compute_mydir(__file__)
+
+    NO_DEBUG_INFO_TESTCASE = True
+
+    def setUp(self):
+        TestBase.setUp(self)
+        # Find the line number to break for main.c.
+        self.line = line_number(
+            'main.cpp',
+            '// Run here before printing memory regions')
+
+    def test(self):
+        self.build()
+
+        # Set breakpoint in main and run
+        self.runCmd("file " + self.getBuildArtifact("a.out"), CURRENT_EXECUTABLE_SET)
+        lldbutil.run_break_set_by_file_and_line(
+            self, "main.cpp", self.line, num_expected_locations=-1, loc_exact=True)
+
+        self.runCmd("run", RUN_SUCCEEDED)
+
+        interp = self.dbg.GetCommandInterpreter()
+        result = lldb.SBCommandReturnObject()
+
+        # Test that the first 'memory region' command prints the usage.
+        interp.HandleCommand("memory region", result)
+        self.assertFalse(result.Succeeded())
+        self.assertRegexpMatches(result.GetError(), "Usage: memory region ADDR")
+
+        # Now let's print the memory region starting at 0 which should always work.
+        interp.HandleCommand("memory region 0x0", result)
+        self.assertTrue(result.Succeeded())
+        self.assertRegexpMatches(result.GetOutput(), "\\[0x0+-")
+
+        # Keep printing memory regions until we printed all of them.
+        while True:
+            interp.HandleCommand("memory region", result)
+            if not result.Succeeded():
+                break
+
+        # Now that we reached the end, 'memory region' should again print the usage.
+        interp.HandleCommand("memory region", result)
+        self.assertFalse(result.Succeeded())
+        self.assertRegexpMatches(result.GetError(), "Usage: memory region ADDR")

packages/Python/lldbsuite/test/functionalities/memory-region/main.cpp

+#include <iostream>
+
+int main (int argc, char const **argv) {
+  std::cout << "Program with sections" << std::endl;
+  return 0; // Run here before printing memory regions
+}