This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] Skip printing duplicate nodes, even if nodes have multiple predecessors/successors
ClosedPublic

Authored by george.karpenkov on Sep 7 2018, 5:11 PM.

Reviewers

dcoughlin
NoQ

Commits

Summary

Still generate a node, but leave the redundant field empty

Yeah, i guess that's a good thing to know.

clang/lib/StaticAnalyzer/Core/ExprEngine.cpp
3182 ↗	(On Diff #164546)	Compare state refs directly?
clang/test/Analysis/copy-elision.cpp
6 ↗	(On Diff #164546)	?

NoQ accepted this revision.Sep 14 2018, 5:55 PM

This revision is now accepted and ready to land.Sep 14 2018, 5:55 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

StaticAnalyzer/

Core/

7 lines

Show First 20 Lines • Show All 3,171 Lines • ▼ Show 20 Lines	static std::string getNodeLabel(const ExplodedNode N, void){
ExplodedGraph &Graph =		ExplodedGraph &Graph =
static_cast<ExprEngine *>(State->getStateManager().getOwningEngine())		static_cast<ExprEngine *>(State->getStateManager().getOwningEngine())
->getGraph();		->getGraph();

Out << "StateID: " << State->getID() << " (" << (const void *)State.get()		Out << "StateID: " << State->getID() << " (" << (const void *)State.get()
<< ")"		<< ")"
<< " NodeID: " << N->getID(&Graph) << " (" << (const void *)N << ")\\\|";		<< " NodeID: " << N->getID(&Graph) << " (" << (const void *)N << ")\\\|";

		bool SameAsAllPredecessors =
		std::all_of(N->pred_begin(), N->pred_end(), [&](const ExplodedNode *P) {
		return P->getState() == State;
		});
		if (!SameAsAllPredecessors)
State->printDOT(Out, N->getLocationContext());		State->printDOT(Out, N->getLocationContext());
return Out.str();		return Out.str();
}		}
};		};

} // namespace llvm		} // namespace llvm
#endif		#endif

void ExprEngine::ViewGraph(bool trim) {		void ExprEngine::ViewGraph(bool trim) {
▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines