Check if a terminal supports colors on Windows properly

[xbolva00]

Summary

Previously we SetUseColor(true) wrongly when output was not a terminal so it broken some (not public) bots.

Thanks for issue report, @stella.stamenova

[stella.stamenova]

Thanks!

lldb/trunk/source/Core/Debugger.cpp

Debugger::Debugger(lldb::LogOutputCallback log_callback, void *baton)
   // Turn off use-color if we don't write to a terminal with color support.
   if (!m_output_file_sp->GetFile().GetIsTerminalWithColors())
     SetUseColor(false);
 
 #if defined(_WIN32) && defined(ENABLE_VIRTUAL_TERMINAL_PROCESSING)
   // Enabling use of ANSI color codes because LLDB is using them to highlight
   // text.
   llvm::sys::Process::UseANSIEscapeCodes(true);
-  SetUseColor(true);
 #endif
 }
 
 Debugger::~Debugger() { Clear(); }
 
 void Debugger::Clear() {
   //----------------------------------------------------------------------
   // Make sure we call this function only once. With the C++ global destructor

lldb/trunk/source/Host/common/File.cpp

void File::CalculateInteractiveAndTerminal() {
   const int fd = GetDescriptor();
   if (fd >= 0) {
     m_is_interactive = eLazyBoolNo;
     m_is_real_terminal = eLazyBoolNo;
 #if defined(_WIN32)
     if (_isatty(fd)) {
       m_is_interactive = eLazyBoolYes;
       m_is_real_terminal = eLazyBoolYes;
+#if defined(ENABLE_VIRTUAL_TERMINAL_PROCESSING)
+      m_supports_colors = eLazyBoolYes;
+#endif
     }
 #else
     if (isatty(fd)) {
       m_is_interactive = eLazyBoolYes;
       struct winsize window_size;
       if (::ioctl(fd, TIOCGWINSZ, &window_size) == 0) {
         if (window_size.ws_col > 0) {
           m_is_real_terminal = eLazyBoolYes;