Page MenuHomePhabricator

[libomptarget][CUDA] Use cuDeviceGetAttribute, NFCI.
ClosedPublic

Authored by Hahnfeld on Sep 4 2018, 6:04 AM.

Details

Summary

cuDeviceGetProperties has apparently been deprecated since CUDA 5.0.
Nvidia started using annotations only in CUDA 9.2, so nobody noticed
nor cared before.
The new function returns the same values, tested with a P100.

Diff Detail

Repository
rL LLVM

Event Timeline

Hahnfeld created this revision.Sep 4 2018, 6:04 AM
kkwli0 added a subscriber: kkwli0.Sep 4 2018, 6:16 AM
kkwli0 added inline comments.
libomptarget/plugins/cuda/src/rtl.cpp
305 ↗(On Diff #163793)

exploiting

Hahnfeld marked an inline comment as done.Sep 4 2018, 6:25 AM
Hahnfeld added inline comments.
libomptarget/plugins/cuda/src/rtl.cpp
305 ↗(On Diff #163793)

Typo corrected locally.

grokos accepted this revision.Sep 4 2018, 8:08 AM

Looks good.

This revision is now accepted and ready to land.Sep 4 2018, 8:08 AM
This revision was automatically updated to reflect the committed changes.
Hahnfeld marked an inline comment as done.