This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Provide a custom target to install LLVM libraries
ClosedPublic

Authored by phosek on Sep 3 2018, 2:19 PM.

Details

Summary

This simplifies installing all LLVM libraries when doing component
build; now you can include llvm-libraries in distribution components.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Sep 3 2018, 2:19 PM
beanz added a comment.Sep 4 2018, 11:09 AM

One small comment below. Otherwise LGTM.

llvm/CMakeLists.txt
986

Should probably wrap this in if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY) because that variable gates generating the install-${lib} targets, so it will explode with missing targets if LLVM_INSTALL_TOOLCHAIN_ONLY=On.

phosek marked an inline comment as done.Sep 4 2018, 11:10 AM
phosek added inline comments.
llvm/CMakeLists.txt
986

It's already in the if(NOT LLVM_INSTALL_TOOLCHAIN_ONLY) block that starts at line 949.

beanz accepted this revision.Sep 4 2018, 11:11 AM

LGTM! Didn't look back through enough context.

This revision is now accepted and ready to land.Sep 4 2018, 11:11 AM
This revision was automatically updated to reflect the committed changes.
phosek marked an inline comment as done.