This is an archive of the discontinued LLVM Phabricator instance.

Differential D51565

Move FeatureAES from SLM, WSM and SNB to GLM and SKL
ClosedPublic

Authored by thiagomacieira on Aug 31 2018, 6:51 PM.

Details

Reviewers
erichkeane
craig.topper
Commits
rG911ddd6db532: Move FeatureAES from SLM, WSM and SNB to GLM and SKL
rL341861: Move FeatureAES from SLM, WSM and SNB to GLM and SKL
Summary

Complements https://reviews.llvm.org/D51510 and matches https://gcc.gnu.org/ml/gcc-patches/2018-08/msg01940.html

GoldmontProc already has FeatureAES.

Diff Detail

Repository
rL LLVM

Event Timeline

thiagomacieira created this revision.Aug 31 2018, 6:51 PM
Herald added a subscriber: llvm-commits. · View Herald TranscriptAug 31 2018, 6:51 PM
thiagomacieira added inline comments.Aug 31 2018, 6:53 PM
lib/Target/X86/X86.td
627

Already here.

craig.topper accepted this revision.Sep 1 2018, 4:15 AM

LGTM

This revision is now accepted and ready to land.Sep 1 2018, 4:15 AM
Closed by commit rL341861: Move FeatureAES from SLM, WSM and SNB to GLM and SKL (authored by erichkeane). · Explain WhySep 10 2018, 2:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
X86/
4 lines

Diff 163614

lib/Target/X86/X86.td

Show First 20 Lines • Show All 583 Lines • ▼ Show 20 Linesclass SilvermontProc<string Name> : ProcessorModel<Name, SLMModel, [
FeatureSSE42, FeatureSSE42,
FeatureFXSR, FeatureFXSR,
FeatureNOPL, FeatureNOPL,
Feature64Bit, Feature64Bit,
FeatureCMPXCHG16B, FeatureCMPXCHG16B,
FeatureMOVBE, FeatureMOVBE,
FeaturePOPCNT, FeaturePOPCNT,
FeaturePCLMUL, FeaturePCLMUL,
FeatureAES,
FeatureSlowDivide64, FeatureSlowDivide64,
FeatureSlowTwoMemOps, FeatureSlowTwoMemOps,
FeaturePRFCHW, FeaturePRFCHW,
FeatureSlowLEA, FeatureSlowLEA,
FeatureSlowIncDec, FeatureSlowIncDec,
FeatureSlowPMULLD, FeatureSlowPMULLD,
FeatureRDRAND, FeatureRDRAND,
FeatureLAHFSAHF, FeatureLAHFSAHF,
Show All 19 Linesdef GLMFeatures : ProcessorFeatures<[], [
FeatureSSE42, FeatureSSE42,
FeatureFXSR, FeatureFXSR,
FeatureNOPL, FeatureNOPL,
Feature64Bit, Feature64Bit,
FeatureCMPXCHG16B, FeatureCMPXCHG16B,
FeatureMOVBE, FeatureMOVBE,
FeaturePOPCNT, FeaturePOPCNT,
FeaturePCLMUL, FeaturePCLMUL,
FeatureAES, FeatureAES,
thiagomacieiraAuthorUnsubmitted
Not Done
ReplyInline Actions

Already here.

thiagomacieira: Already here.
FeaturePRFCHW, FeaturePRFCHW,
FeatureSlowTwoMemOps, FeatureSlowTwoMemOps,
FeatureSlowLEA, FeatureSlowLEA,
FeatureSlowIncDec, FeatureSlowIncDec,
FeatureLAHFSAHF, FeatureLAHFSAHF,
FeatureMPX, FeatureMPX,
FeatureSHA, FeatureSHA,
FeatureRDRAND, FeatureRDRAND,
▲ Show 20 Lines • Show All 60 Lines • ▼ Show 20 Linesclass WestmereProc<string Name> : ProcessorModel<Name, SandyBridgeModel, [
FeatureCMOV, FeatureCMOV,
FeatureMMX, FeatureMMX,
FeatureSSE42, FeatureSSE42,
FeatureFXSR, FeatureFXSR,
FeatureNOPL, FeatureNOPL,
Feature64Bit, Feature64Bit,
FeatureCMPXCHG16B, FeatureCMPXCHG16B,
FeaturePOPCNT, FeaturePOPCNT,
FeatureAES,
FeaturePCLMUL, FeaturePCLMUL,
FeatureLAHFSAHF, FeatureLAHFSAHF,
FeatureMacroFusion FeatureMacroFusion
]>; ]>;
def : WestmereProc<"westmere">; def : WestmereProc<"westmere">;
// SSE is not listed here since llvm treats AVX as a reimplementation of SSE, // SSE is not listed here since llvm treats AVX as a reimplementation of SSE,
// rather than a superset. // rather than a superset.
def SNBFeatures : ProcessorFeatures<[], [ def SNBFeatures : ProcessorFeatures<[], [
FeatureX87, FeatureX87,
FeatureCMOV, FeatureCMOV,
FeatureMMX, FeatureMMX,
FeatureAVX, FeatureAVX,
FeatureFXSR, FeatureFXSR,
FeatureNOPL, FeatureNOPL,
Feature64Bit, Feature64Bit,
FeatureCMPXCHG16B, FeatureCMPXCHG16B,
FeaturePOPCNT, FeaturePOPCNT,
FeatureAES,
FeatureSlowDivide64, FeatureSlowDivide64,
FeaturePCLMUL, FeaturePCLMUL,
FeatureXSAVE, FeatureXSAVE,
FeatureXSAVEOPT, FeatureXSAVEOPT,
FeatureLAHFSAHF, FeatureLAHFSAHF,
FeatureSlow3OpsLEA, FeatureSlow3OpsLEA,
FeatureFastScalarFSQRT, FeatureFastScalarFSQRT,
FeatureFastSHLDRotate, FeatureFastSHLDRotate,
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Linesclass BroadwellProc<string Name> : ProcModel<Name, BroadwellModel,
BDWFeatures.Value, [ BDWFeatures.Value, [
ProcIntelBDW, ProcIntelBDW,
FeaturePOPCNTFalseDeps, FeaturePOPCNTFalseDeps,
FeatureLZCNTFalseDeps FeatureLZCNTFalseDeps
]>; ]>;
def : BroadwellProc<"broadwell">; def : BroadwellProc<"broadwell">;
def SKLFeatures : ProcessorFeatures<BDWFeatures.Value, [ def SKLFeatures : ProcessorFeatures<BDWFeatures.Value, [
FeatureAES,
FeatureMPX, FeatureMPX,
FeatureRTM, FeatureRTM,
FeatureXSAVEC, FeatureXSAVEC,
FeatureXSAVES, FeatureXSAVES,
FeatureCLFLUSHOPT, FeatureCLFLUSHOPT,
FeatureFastVectorFSQRT FeatureFastVectorFSQRT
]>; ]>;
▲ Show 20 Lines • Show All 448 Lines • Show Last 20 Lines