This is an archive of the discontinued LLVM Phabricator instance.

lit: Use sys.executable for executing builtin commands
ClosedPublic

Authored by tstellar on Aug 30 2018, 2:47 PM.

Reviewers

• ddunbar
stella.stamenova

Commits

Summary

The python executable may not exist on all systems so use sys.executable
instead.

LGTM.

This revision is now accepted and ready to land.Aug 30 2018, 2:50 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

utils/

lit/

2 lines

Show First 20 Lines • Show All 873 Lines • ▼ Show 20 Lines	for i,j in enumerate(cmd.commands):
f = tempfile.NamedTemporaryFile(delete=False)		f = tempfile.NamedTemporaryFile(delete=False)
f.close()		f.close()
named_temp_files.append(f.name)		named_temp_files.append(f.name)
args[i] = arg.replace(kDevNull, f.name)		args[i] = arg.replace(kDevNull, f.name)

# Expand all glob expressions		# Expand all glob expressions
args = expand_glob_expressions(args, cmd_shenv.cwd)		args = expand_glob_expressions(args, cmd_shenv.cwd)
if is_builtin_cmd:		if is_builtin_cmd:
args.insert(0, "python")		args.insert(0, sys.executable)
args[1] = os.path.join(builtin_commands_dir ,args[1] + ".py")		args[1] = os.path.join(builtin_commands_dir ,args[1] + ".py")

# On Windows, do our own command line quoting for better compatibility		# On Windows, do our own command line quoting for better compatibility
# with some core utility distributions.		# with some core utility distributions.
if kIsWindows:		if kIsWindows:
args = quote_windows_command(args)		args = quote_windows_command(args)

try:		try:
▲ Show 20 Lines • Show All 693 Lines • Show Last 20 Lines