This is an archive of the discontinued LLVM Phabricator instance.

Add some context to fatal verifier errors
ClosedPublic

Authored by david2050 on Aug 28 2018, 3:07 PM.

Reviewers

mehdi_amini
modocache

Commits

Summary

Add function name when verification fails as an initial breadcrumb for debugging.

Nice! This seems like a plain improvement in terms of debugging, thanks.

This revision is now accepted and ready to land.Sep 3 2018, 9:42 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

lib/

IR/

5 lines

Show First 20 Lines • Show All 4,724 Lines • ▼ Show 20 Lines	struct VerifierLegacyPass : public FunctionPass {

bool doInitialization(Module &M) override {		bool doInitialization(Module &M) override {
V = llvm::make_unique<Verifier>(		V = llvm::make_unique<Verifier>(
&dbgs(), /ShouldTreatBrokenDebugInfoAsError=/false, M);		&dbgs(), /ShouldTreatBrokenDebugInfoAsError=/false, M);
return false;		return false;
}		}

bool runOnFunction(Function &F) override {		bool runOnFunction(Function &F) override {
if (!V->verify(F) && FatalErrors)		if (!V->verify(F) && FatalErrors) {
		errs() << "in function " << F.getName() << '\n';
report_fatal_error("Broken function found, compilation aborted!");		report_fatal_error("Broken function found, compilation aborted!");
		}
return false;		return false;
}		}

bool doFinalization(Module &M) override {		bool doFinalization(Module &M) override {
bool HasErrors = false;		bool HasErrors = false;
for (Function &F : M)		for (Function &F : M)
if (F.isDeclaration())		if (F.isDeclaration())
HasErrors \|= !V->verify(F);		HasErrors \|= !V->verify(F);
▲ Show 20 Lines • Show All 395 Lines • Show Last 20 Lines