This is an archive of the discontinued LLVM Phabricator instance.

Differential D51351

AMDGPU: Remove nan tests in class if src is nnan
ClosedPublic

Authored by arsenm on Aug 28 2018, 5:07 AM.

Details

Reviewers
rampitec
b-sumner

Diff Detail

Event Timeline

arsenm created this revision.Aug 28 2018, 5:07 AM
Herald added subscribers: t-tye, tpr, dstuttard and 5 others. · View Herald TranscriptAug 28 2018, 5:07 AM
rampitec accepted this revision.Aug 28 2018, 9:06 AM

LGTM

This revision is now accepted and ready to land.Aug 28 2018, 9:06 AM
arsenm closed this revision.Aug 28 2018, 11:11 AM

340850

Revision Contents

PathSize
lib/
Transforms/
InstCombine/
7 lines
test/
Transforms/
InstCombine/
AMDGPU/
33 lines

Diff 162834

lib/Transforms/InstCombine/InstCombineCalls.cpp

Show First 20 Lines • Show All 3,276 Lines • ▼ Show 20 Lines if (Mask == (N_ZERO | P_ZERO)) {
// Equivalent of == 0. // Equivalent of == 0.
Value *FCmp = Builder.CreateFCmpOEQ( Value *FCmp = Builder.CreateFCmpOEQ(
Src0, ConstantFP::get(Src0->getType(), 0.0)); Src0, ConstantFP::get(Src0->getType(), 0.0));
FCmp->takeName(II); FCmp->takeName(II);
return replaceInstUsesWith(*II, FCmp); return replaceInstUsesWith(*II, FCmp);
} }
// fp_class (nnan x), qnan|snan|other -> fp_class (nnan x), other
if (((Mask & S_NAN) || (Mask & Q_NAN)) && isKnownNeverNaN(Src0, &TLI)) {
II->setArgOperand(1, ConstantInt::get(Src1->getType(),
Mask & ~(S_NAN | Q_NAN)));
return II;
}
const ConstantFP *CVal = dyn_cast<ConstantFP>(Src0); const ConstantFP *CVal = dyn_cast<ConstantFP>(Src0);
if (!CVal) { if (!CVal) {
if (isa<UndefValue>(Src0)) if (isa<UndefValue>(Src0))
return replaceInstUsesWith(*II, UndefValue::get(II->getType())); return replaceInstUsesWith(*II, UndefValue::get(II->getType()));
// Clamp mask to used bits // Clamp mask to used bits
if ((Mask & FullMask) != Mask) { if ((Mask & FullMask) != Mask) {
CallInst *NewCall = Builder.CreateCall(II->getCalledFunction(), CallInst *NewCall = Builder.CreateCall(II->getCalledFunction(),
▲ Show 20 Lines • Show All 1,273 Lines • Show Last 20 Lines

test/Transforms/InstCombine/AMDGPU/amdgcn-intrinsics.ll

Show First 20 Lines • Show All 619 Lines • ▼ Show 20 Lines
; CHECK-LABEL: @test_constant_class_snan_test_pinf_f64( ; CHECK-LABEL: @test_constant_class_snan_test_pinf_f64(
; CHECK: ret i1 false ; CHECK: ret i1 false
define i1 @test_constant_class_snan_test_pinf_f64() nounwind { define i1 @test_constant_class_snan_test_pinf_f64() nounwind {
%val = call i1 @llvm.amdgcn.class.f64(double 0x7FF0000000000001, i32 512) %val = call i1 @llvm.amdgcn.class.f64(double 0x7FF0000000000001, i32 512)
ret i1 %val ret i1 %val
} }
; CHECK-LABEL: @test_class_is_snan_nnan_src(
; CHECK-NEXT: ret i1 false
define i1 @test_class_is_snan_nnan_src(float %x) {
%nnan = fadd nnan float %x, 1.0
%class = call i1 @llvm.amdgcn.class.f32(float %nnan, i32 1)
ret i1 %class
}
; CHECK-LABEL: @test_class_is_qnan_nnan_src(
; CHECK-NEXT: ret i1 false
define i1 @test_class_is_qnan_nnan_src(float %x) {
%nnan = fadd nnan float %x, 1.0
%class = call i1 @llvm.amdgcn.class.f32(float %nnan, i32 2)
ret i1 %class
}
; CHECK-LABEL: @test_class_is_nan_nnan_src(
; CHECK-NEXT: ret i1 false
define i1 @test_class_is_nan_nnan_src(float %x) {
%nnan = fadd nnan float %x, 1.0
%class = call i1 @llvm.amdgcn.class.f32(float %nnan, i32 3)
ret i1 %class
}
; CHECK-LABEL: @test_class_is_nan_other_nnan_src(
; CHECK-NEXT: %nnan = fadd nnan float %x, 1.000000e+00
; CHECK-NEXT: %class = call i1 @llvm.amdgcn.class.f32(float %nnan, i32 264)
define i1 @test_class_is_nan_other_nnan_src(float %x) {
%nnan = fadd nnan float %x, 1.0
%class = call i1 @llvm.amdgcn.class.f32(float %nnan, i32 267)
ret i1 %class
}
; -------------------------------------------------------------------- ; --------------------------------------------------------------------
; llvm.amdgcn.cos ; llvm.amdgcn.cos
; -------------------------------------------------------------------- ; --------------------------------------------------------------------
declare float @llvm.amdgcn.cos.f32(float) nounwind readnone declare float @llvm.amdgcn.cos.f32(float) nounwind readnone
declare float @llvm.fabs.f32(float) nounwind readnone declare float @llvm.fabs.f32(float) nounwind readnone
; CHECK-LABEL: @cos_fneg_f32( ; CHECK-LABEL: @cos_fneg_f32(
; CHECK: %cos = call float @llvm.amdgcn.cos.f32(float %x) ; CHECK: %cos = call float @llvm.amdgcn.cos.f32(float %x)
▲ Show 20 Lines • Show All 1,288 Lines • Show Last 20 Lines