This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP][Fix] Ensure comparison between unsigned values.
ClosedPublic

Authored by gtbercea on Aug 27 2018, 7:06 AM.

Reviewers

Commits

Summary

Ensure the values being compared are both unsigned.

I think removal of the cast looks better than casting to own type.

Remove cast.

LGTM

This revision is now accepted and ready to land.Aug 27 2018, 7:41 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

runtime/

src/

2 lines

Show First 20 Lines • Show All 995 Lines • ▼ Show 20 Lines	int func(unsigned ncounts, unsigned long long *counts, \
if ((str > 0) ? (lb < ub) : (lb > ub)) { \		if ((str > 0) ? (lb < ub) : (lb > ub)) { \
KMP_DISPATCH_INIT_ULL(&loc, gtid, (schedule), lb, \		KMP_DISPATCH_INIT_ULL(&loc, gtid, (schedule), lb, \
(str > 0) ? (ub - 1) : (ub + 1), str, chunk_sz, \		(str > 0) ? (ub - 1) : (ub + 1), str, chunk_sz, \
TRUE); \		TRUE); \
status = \		status = \
KMP_DISPATCH_NEXT_ULL(&loc, gtid, NULL, (kmp_uint64 *)p_lb, \		KMP_DISPATCH_NEXT_ULL(&loc, gtid, NULL, (kmp_uint64 *)p_lb, \
(kmp_uint64 )p_ub, (kmp_int64 )&stride); \		(kmp_uint64 )p_ub, (kmp_int64 )&stride); \
if (status) { \		if (status) { \
KMP_DEBUG_ASSERT((long long)stride == str); \		KMP_DEBUG_ASSERT(stride == str); \
*p_ub += (str > 0) ? 1 : -1; \		*p_ub += (str > 0) ? 1 : -1; \
} \		} \
} else { \		} else { \
status = 0; \		status = 0; \
} \		} \
KMP_DOACROSS_FINI(status, gtid); \		KMP_DOACROSS_FINI(status, gtid); \
\		\
KA_TRACE( \		KA_TRACE( \
▲ Show 20 Lines • Show All 988 Lines • Show Last 20 Lines