This is an archive of the discontinued LLVM Phabricator instance.

Differential D51092

[LibCalls] Added returned attribute to libcalls
ClosedPublic

Authored by xbolva00 on Aug 22 2018, 3:20 AM.

Details

Reviewers
efriedma
Commits
rG8715e034776d: [LibCalls] Added returned attribute to libcalls
rL340512: [LibCalls] Added returned attribute to libcalls

Diff Detail

Event Timeline

xbolva00 created this revision.Aug 22 2018, 3:20 AM
Herald added a subscriber: llvm-commits. · View Herald TranscriptAug 22 2018, 3:20 AM
efriedma accepted this revision.Aug 22 2018, 11:38 AM

LGTM with nits.

lib/Transforms/Utils/BuildLibCalls.cpp
162–164

Please explicitly mark fallthrough using LLVM_FALLTHROUGH.

277

Please explicitly mark fallthrough using LLVM_FALLTHROUGH.

This revision is now accepted and ready to land.Aug 22 2018, 11:38 AM
xbolva00 updated this revision to Diff 162037.Aug 22 2018, 1:21 PM
  • Added LLVM_FALLTHROUGH
Closed by commit rL340512: [LibCalls] Added returned attribute to libcalls (authored by xbolva00). · Explain WhyAug 22 2018, 10:19 PM
This revision was automatically updated to reflect the committed changes.
jonpa mentioned this in D103992: [InstCombine / BuildLibCalls] Add parameter attributes from the prototype..Jun 15 2021, 11:46 AM

Revision Contents

PathSize
lib/
Transforms/
Utils/
19 lines
test/
Transforms/
InferFunctionAttrs/
12 lines

Diff 162037

lib/Transforms/Utils/BuildLibCalls.cpp

Show All 32 Lines
STATISTIC(NumReadNone, "Number of functions inferred as readnone"); STATISTIC(NumReadNone, "Number of functions inferred as readnone");
STATISTIC(NumReadOnly, "Number of functions inferred as readonly"); STATISTIC(NumReadOnly, "Number of functions inferred as readonly");
STATISTIC(NumArgMemOnly, "Number of functions inferred as argmemonly"); STATISTIC(NumArgMemOnly, "Number of functions inferred as argmemonly");
STATISTIC(NumNoUnwind, "Number of functions inferred as nounwind"); STATISTIC(NumNoUnwind, "Number of functions inferred as nounwind");
STATISTIC(NumNoCapture, "Number of arguments inferred as nocapture"); STATISTIC(NumNoCapture, "Number of arguments inferred as nocapture");
STATISTIC(NumReadOnlyArg, "Number of arguments inferred as readonly"); STATISTIC(NumReadOnlyArg, "Number of arguments inferred as readonly");
STATISTIC(NumNoAlias, "Number of function returns inferred as noalias"); STATISTIC(NumNoAlias, "Number of function returns inferred as noalias");
STATISTIC(NumNonNull, "Number of function returns inferred as nonnull returns"); STATISTIC(NumNonNull, "Number of function returns inferred as nonnull returns");
STATISTIC(NumReturnedArg, "Number of arguments inferred as returned");
static bool setDoesNotAccessMemory(Function &F) { static bool setDoesNotAccessMemory(Function &F) {
if (F.doesNotAccessMemory()) if (F.doesNotAccessMemory())
return false; return false;
F.setDoesNotAccessMemory(); F.setDoesNotAccessMemory();
++NumReadNone; ++NumReadNone;
return true; return true;
} }
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Lines assert(F.getReturnType()->isPointerTy() &&
"nonnull applies only to pointers"); "nonnull applies only to pointers");
if (F.hasAttribute(AttributeList::ReturnIndex, Attribute::NonNull)) if (F.hasAttribute(AttributeList::ReturnIndex, Attribute::NonNull))
return false; return false;
F.addAttribute(AttributeList::ReturnIndex, Attribute::NonNull); F.addAttribute(AttributeList::ReturnIndex, Attribute::NonNull);
++NumNonNull; ++NumNonNull;
return true; return true;
} }
static bool setReturnedArg(Function &F, unsigned ArgNo) {
if (F.hasParamAttribute(ArgNo, Attribute::Returned))
return false;
F.addParamAttr(ArgNo, Attribute::Returned);
++NumReturnedArg;
return true;
}
static bool setNonLazyBind(Function &F) { static bool setNonLazyBind(Function &F) {
if (F.hasFnAttribute(Attribute::NonLazyBind)) if (F.hasFnAttribute(Attribute::NonLazyBind))
return false; return false;
F.addFnAttr(Attribute::NonLazyBind); F.addFnAttr(Attribute::NonLazyBind);
return true; return true;
} }
bool llvm::inferLibFuncAttributes(Function &F, const TargetLibraryInfo &TLI) { bool llvm::inferLibFuncAttributes(Function &F, const TargetLibraryInfo &TLI) {
Show All 26 Linesbool llvm::inferLibFuncAttributes(Function &F, const TargetLibraryInfo &TLI) {
case LibFunc_strtoll: case LibFunc_strtoll:
case LibFunc_strtold: case LibFunc_strtold:
case LibFunc_strtoull: case LibFunc_strtoull:
Changed |= setDoesNotThrow(F); Changed |= setDoesNotThrow(F);
Changed |= setDoesNotCapture(F, 1); Changed |= setDoesNotCapture(F, 1);
Changed |= setOnlyReadsMemory(F, 0); Changed |= setOnlyReadsMemory(F, 0);
return Changed; return Changed;
case LibFunc_strcpy: case LibFunc_strcpy:
case LibFunc_stpcpy: case LibFunc_strncpy:
case LibFunc_strcat: case LibFunc_strcat:
case LibFunc_strncat: case LibFunc_strncat:
case LibFunc_strncpy: Changed |= setReturnedArg(F, 0);
LLVM_FALLTHROUGH;
case LibFunc_stpcpy:
efriedmaUnsubmitted
Not Done
ReplyInline Actions

Please explicitly mark fallthrough using LLVM_FALLTHROUGH.

efriedma: Please explicitly mark fallthrough using LLVM_FALLTHROUGH.
case LibFunc_stpncpy: case LibFunc_stpncpy:
Changed |= setDoesNotThrow(F); Changed |= setDoesNotThrow(F);
Changed |= setDoesNotCapture(F, 1); Changed |= setDoesNotCapture(F, 1);
Changed |= setOnlyReadsMemory(F, 1); Changed |= setOnlyReadsMemory(F, 1);
return Changed; return Changed;
case LibFunc_strxfrm: case LibFunc_strxfrm:
Changed |= setDoesNotThrow(F); Changed |= setDoesNotThrow(F);
Changed |= setDoesNotCapture(F, 0); Changed |= setDoesNotCapture(F, 0);
▲ Show 20 Lines • Show All 95 Lines • ▼ Show 20 Lines case LibFunc_memrchr:
return Changed; return Changed;
case LibFunc_modf: case LibFunc_modf:
case LibFunc_modff: case LibFunc_modff:
case LibFunc_modfl: case LibFunc_modfl:
Changed |= setDoesNotThrow(F); Changed |= setDoesNotThrow(F);
Changed |= setDoesNotCapture(F, 1); Changed |= setDoesNotCapture(F, 1);
return Changed; return Changed;
case LibFunc_memcpy: case LibFunc_memcpy:
case LibFunc_memmove:
Changed |= setReturnedArg(F, 0);
efriedmaUnsubmitted
Not Done
ReplyInline Actions

Please explicitly mark fallthrough using LLVM_FALLTHROUGH.

efriedma: Please explicitly mark fallthrough using LLVM_FALLTHROUGH.
LLVM_FALLTHROUGH;
case LibFunc_mempcpy: case LibFunc_mempcpy:
case LibFunc_memccpy: case LibFunc_memccpy:
case LibFunc_memmove:
Changed |= setDoesNotThrow(F); Changed |= setDoesNotThrow(F);
Changed |= setDoesNotCapture(F, 1); Changed |= setDoesNotCapture(F, 1);
Changed |= setOnlyReadsMemory(F, 1); Changed |= setOnlyReadsMemory(F, 1);
return Changed; return Changed;
case LibFunc_memcpy_chk: case LibFunc_memcpy_chk:
Changed |= setDoesNotThrow(F); Changed |= setDoesNotThrow(F);
return Changed; return Changed;
case LibFunc_memalign: case LibFunc_memalign:
▲ Show 20 Lines • Show All 925 Lines • Show Last 20 Lines

test/Transforms/InferFunctionAttrs/annotate.ll

Show First 20 Lines • Show All 619 Lines • ▼ Show 20 Lines
declare i8* @memccpy(i8*, i8*, i32, i64) declare i8* @memccpy(i8*, i8*, i32, i64)
; CHECK: declare i8* @memchr(i8*, i32, i64) [[G1]] ; CHECK: declare i8* @memchr(i8*, i32, i64) [[G1]]
declare i8* @memchr(i8*, i32, i64) declare i8* @memchr(i8*, i32, i64)
; CHECK: declare i32 @memcmp(i8* nocapture, i8* nocapture, i64) [[G1]] ; CHECK: declare i32 @memcmp(i8* nocapture, i8* nocapture, i64) [[G1]]
declare i32 @memcmp(i8*, i8*, i64) declare i32 @memcmp(i8*, i8*, i64)
; CHECK: declare i8* @memcpy(i8*, i8* nocapture readonly, i64) [[G0]] ; CHECK: declare i8* @memcpy(i8* returned, i8* nocapture readonly, i64) [[G0]]
declare i8* @memcpy(i8*, i8*, i64) declare i8* @memcpy(i8*, i8*, i64)
; CHECK: declare i8* @mempcpy(i8*, i8* nocapture readonly, i64) [[G0]] ; CHECK: declare i8* @mempcpy(i8*, i8* nocapture readonly, i64) [[G0]]
declare i8* @mempcpy(i8*, i8*, i64) declare i8* @mempcpy(i8*, i8*, i64)
; CHECK: declare i8* @memmove(i8*, i8* nocapture readonly, i64) [[G0]] ; CHECK: declare i8* @memmove(i8* returned, i8* nocapture readonly, i64) [[G0]]
declare i8* @memmove(i8*, i8*, i64) declare i8* @memmove(i8*, i8*, i64)
; CHECK: declare i8* @memset(i8*, i32, i64) ; CHECK: declare i8* @memset(i8*, i32, i64)
declare i8* @memset(i8*, i32, i64) declare i8* @memset(i8*, i32, i64)
; CHECK: declare i32 @mkdir(i8* nocapture readonly, i16 zeroext) [[G0]] ; CHECK: declare i32 @mkdir(i8* nocapture readonly, i16 zeroext) [[G0]]
declare i32 @mkdir(i8*, i16 zeroext) declare i32 @mkdir(i8*, i16 zeroext)
▲ Show 20 Lines • Show All 181 Lines • ▼ Show 20 Lines
declare i8* @stpcpy(i8*, i8*) declare i8* @stpcpy(i8*, i8*)
; CHECK: declare i8* @stpncpy(i8*, i8* nocapture readonly, i64) [[G0]] ; CHECK: declare i8* @stpncpy(i8*, i8* nocapture readonly, i64) [[G0]]
declare i8* @stpncpy(i8*, i8*, i64) declare i8* @stpncpy(i8*, i8*, i64)
; CHECK: declare i32 @strcasecmp(i8* nocapture, i8* nocapture) [[G1]] ; CHECK: declare i32 @strcasecmp(i8* nocapture, i8* nocapture) [[G1]]
declare i32 @strcasecmp(i8*, i8*) declare i32 @strcasecmp(i8*, i8*)
; CHECK: declare i8* @strcat(i8*, i8* nocapture readonly) [[G0]] ; CHECK: declare i8* @strcat(i8* returned, i8* nocapture readonly) [[G0]]
declare i8* @strcat(i8*, i8*) declare i8* @strcat(i8*, i8*)
; CHECK: declare i8* @strchr(i8*, i32) [[G1]] ; CHECK: declare i8* @strchr(i8*, i32) [[G1]]
declare i8* @strchr(i8*, i32) declare i8* @strchr(i8*, i32)
; CHECK: declare i32 @strcmp(i8* nocapture, i8* nocapture) [[G1]] ; CHECK: declare i32 @strcmp(i8* nocapture, i8* nocapture) [[G1]]
declare i32 @strcmp(i8*, i8*) declare i32 @strcmp(i8*, i8*)
; CHECK: declare i32 @strcoll(i8* nocapture, i8* nocapture) [[G1]] ; CHECK: declare i32 @strcoll(i8* nocapture, i8* nocapture) [[G1]]
declare i32 @strcoll(i8*, i8*) declare i32 @strcoll(i8*, i8*)
; CHECK: declare i8* @strcpy(i8*, i8* nocapture readonly) [[G0]] ; CHECK: declare i8* @strcpy(i8* returned, i8* nocapture readonly) [[G0]]
declare i8* @strcpy(i8*, i8*) declare i8* @strcpy(i8*, i8*)
; CHECK: declare i64 @strcspn(i8* nocapture, i8* nocapture) [[G1]] ; CHECK: declare i64 @strcspn(i8* nocapture, i8* nocapture) [[G1]]
declare i64 @strcspn(i8*, i8*) declare i64 @strcspn(i8*, i8*)
; CHECK: declare noalias i8* @strdup(i8* nocapture readonly) [[G0]] ; CHECK: declare noalias i8* @strdup(i8* nocapture readonly) [[G0]]
declare i8* @strdup(i8*) declare i8* @strdup(i8*)
; CHECK: declare i64 @strlen(i8* nocapture) [[G2:#[0-9]+]] ; CHECK: declare i64 @strlen(i8* nocapture) [[G2:#[0-9]+]]
declare i64 @strlen(i8*) declare i64 @strlen(i8*)
; CHECK: declare i32 @strncasecmp(i8* nocapture, i8* nocapture, i64) [[G1]] ; CHECK: declare i32 @strncasecmp(i8* nocapture, i8* nocapture, i64) [[G1]]
declare i32 @strncasecmp(i8*, i8*, i64) declare i32 @strncasecmp(i8*, i8*, i64)
; CHECK: declare i8* @strncat(i8*, i8* nocapture readonly, i64) [[G0]] ; CHECK: declare i8* @strncat(i8* returned, i8* nocapture readonly, i64) [[G0]]
declare i8* @strncat(i8*, i8*, i64) declare i8* @strncat(i8*, i8*, i64)
; CHECK: declare i32 @strncmp(i8* nocapture, i8* nocapture, i64) [[G1]] ; CHECK: declare i32 @strncmp(i8* nocapture, i8* nocapture, i64) [[G1]]
declare i32 @strncmp(i8*, i8*, i64) declare i32 @strncmp(i8*, i8*, i64)
; CHECK: declare i8* @strncpy(i8*, i8* nocapture readonly, i64) [[G0]] ; CHECK: declare i8* @strncpy(i8* returned, i8* nocapture readonly, i64) [[G0]]
declare i8* @strncpy(i8*, i8*, i64) declare i8* @strncpy(i8*, i8*, i64)
; CHECK: declare noalias i8* @strndup(i8* nocapture readonly, i64) [[G0]] ; CHECK: declare noalias i8* @strndup(i8* nocapture readonly, i64) [[G0]]
declare i8* @strndup(i8*, i64) declare i8* @strndup(i8*, i64)
; CHECK: declare i64 @strnlen(i8*, i64) ; CHECK: declare i64 @strnlen(i8*, i64)
declare i64 @strnlen(i8*, i64) declare i64 @strnlen(i8*, i64)
▲ Show 20 Lines • Show All 139 Lines • Show Last 20 Lines