This is an archive of the discontinued LLVM Phabricator instance.

[LibCalls] Added returned attribute to libcalls
ClosedPublic

Authored by xbolva00 on Aug 22 2018, 3:20 AM.

Diff Detail

Event Timeline

xbolva00 created this revision.Aug 22 2018, 3:20 AM
efriedma accepted this revision.Aug 22 2018, 11:38 AM

LGTM with nits.

lib/Transforms/Utils/BuildLibCalls.cpp
162–164

Please explicitly mark fallthrough using LLVM_FALLTHROUGH.

277

Please explicitly mark fallthrough using LLVM_FALLTHROUGH.

This revision is now accepted and ready to land.Aug 22 2018, 11:38 AM
xbolva00 updated this revision to Diff 162037.Aug 22 2018, 1:21 PM
  • Added LLVM_FALLTHROUGH
This revision was automatically updated to reflect the committed changes.