Page MenuHomePhabricator

[LICM] Modernize AliasSetTracker handling. NFC
ClosedPublic

Authored by kariddi on Aug 20 2018, 8:33 PM.

Details

Summary

While reading LICM I noticed we had code that uses new/deletes all around LICM to handle AliasSetTracker.

I decided to try and modernize it using unique_ptr<>.

Diff Detail

Repository
rL LLVM

Event Timeline

kariddi created this revision.Aug 20 2018, 8:33 PM

Happy to take a look at this, but Alina has been looking a lot at LICM and related code so wanted to see if she has thoughts first.

kariddi updated this revision to Diff 161644.Aug 20 2018, 11:07 PM

Yeah sure, thanks for suggesting the right person Chandler!

In the meantime added a full diff patch and a little nitpick

asbirlea accepted this revision.Aug 21 2018, 11:08 AM

This is great, thank you for the cleanup!
LGTM.

This revision is now accepted and ready to land.Aug 21 2018, 11:08 AM
This revision was automatically updated to reflect the committed changes.

Thanks Alina!

Committed as r340333