This is an archive of the discontinued LLVM Phabricator instance.

Fix in getAllocationDataForFunction
ClosedPublic

Authored by mjp41 on Aug 20 2018, 1:44 AM.

Reviewers

theraven

Commits

Summary

Correct to use set like behaviour of AllocType. Should check for
subset, not precise value.

Repository

rL LLVM

Build Status

Buildable 21662
Build 21662: arc lint + arc unit

Looks good to me. I will commit it unless anyone objects.

This revision is now accepted and ready to land.Aug 21 2018, 6:22 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

lib/

Analysis/

2 lines

Show First 20 Lines • Show All 144 Lines • ▼ Show 20 Lines	const auto *Iter = find_if(
AllocationFnData, [TLIFn](const std::pair<LibFunc, AllocFnsTy> &P) {		AllocationFnData, [TLIFn](const std::pair<LibFunc, AllocFnsTy> &P) {
return P.first == TLIFn;		return P.first == TLIFn;
});		});

if (Iter == std::end(AllocationFnData))		if (Iter == std::end(AllocationFnData))
return None;		return None;

const AllocFnsTy *FnData = &Iter->second;		const AllocFnsTy *FnData = &Iter->second;
if ((FnData->AllocTy & AllocTy) != FnData->AllocTy)		if ((FnData->AllocTy & AllocTy) == 0)
return None;		return None;

// Check function prototype.		// Check function prototype.
int FstParam = FnData->FstParam;		int FstParam = FnData->FstParam;
int SndParam = FnData->SndParam;		int SndParam = FnData->SndParam;
FunctionType *FTy = Callee->getFunctionType();		FunctionType *FTy = Callee->getFunctionType();

if (FTy->getReturnType() == Type::getInt8PtrTy(FTy->getContext()) &&		if (FTy->getReturnType() == Type::getInt8PtrTy(FTy->getContext()) &&
▲ Show 20 Lines • Show All 800 Lines • Show Last 20 Lines