This is an archive of the discontinued LLVM Phabricator instance.

Add include directory for libxml on macOS
ClosedPublic

Authored by sas on Aug 17 2018, 1:02 PM.

Details

Summary

Builds fail because libxml/xmlreader.h isn't found. Adding the include
directory to the include list fixes the issue. This is what we already do on
non-macOS platforms in the same file.

Diff Detail

Repository
rL LLVM

Event Timeline

sas created this revision.Aug 17 2018, 1:02 PM
lanza added a comment.EditedAug 17 2018, 1:13 PM

How did it ever find the file without the include_directories if it's at /usr/include/libxml2/libxml?

lanza accepted this revision.Aug 17 2018, 1:14 PM
This revision is now accepted and ready to land.Aug 17 2018, 1:14 PM
sas added a comment.Aug 17 2018, 1:16 PM

I have no idea. I discovered this issue while working on our internal 7.0 branch.

clayborg accepted this revision.Aug 22 2018, 3:25 PM
This revision was automatically updated to reflect the committed changes.