This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Remove temporary workaround for function bitcasts
ClosedPublic

Authored by jgravelle-google on Aug 16 2018, 11:32 AM.

Reviewers

Commits

Summary

EM_ASM no longer is lowered as varargs in C, so this workaround is
obsolete.

Yay!

This revision is now accepted and ready to land.Aug 16 2018, 12:00 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

lib/

Target/

WebAssembly/

5 lines

Show First 20 Lines • Show All 251 Lines • ▼ Show 20 Lines	for (auto &UseFunc : Uses) {
FunctionType *Ty = dyn_cast<FunctionType>(PTy->getElementType());		FunctionType *Ty = dyn_cast<FunctionType>(PTy->getElementType());

// If the function is casted to something like i8* as a "generic pointer"		// If the function is casted to something like i8* as a "generic pointer"
// to be later casted to something else, we can't generate a wrapper for it.		// to be later casted to something else, we can't generate a wrapper for it.
// Just ignore such casts for now.		// Just ignore such casts for now.
if (!Ty)		if (!Ty)
continue;		continue;

// Bitcasted vararg functions occur in Emscripten's implementation of
// EM_ASM, so suppress wrappers for them for now.
if (TemporaryWorkarounds && (Ty->isVarArg() \|\| F->isVarArg()))
continue;

auto Pair = Wrappers.insert(std::make_pair(std::make_pair(F, Ty), nullptr));		auto Pair = Wrappers.insert(std::make_pair(std::make_pair(F, Ty), nullptr));
if (Pair.second)		if (Pair.second)
Pair.first->second = CreateWrapper(F, Ty);		Pair.first->second = CreateWrapper(F, Ty);

Function *Wrapper = Pair.first->second;		Function *Wrapper = Pair.first->second;
if (!Wrapper)		if (!Wrapper)
continue;		continue;

Show All 22 Lines