This is an archive of the discontinued LLVM Phabricator instance.

[codeview] Use push_macro to avoid conflicts instead of a prefix
ClosedPublic

Authored by rnk on Aug 16 2018, 10:25 AM.

Details

Summary

This prefix was added in r333421, and it changed our dumper output to
say things like "CVRegEAX" instead of just "EAX". That's a functional
change that I'd rather avoid.

I tested GCC, Clang, and MSVC, and all of them support #pragma
push_macro. They don't issue warnings whem the macro is not defined
either.

I don't have a Mac so I can't test the real termios.h header, but I
looked at the termios.h sources online and looked for other conflicts.
I saw only the CR* macros, so those are the ones we work around.

Diff Detail

Repository
rL LLVM

Event Timeline

rnk created this revision.Aug 16 2018, 10:25 AM
zturner accepted this revision.Aug 16 2018, 10:31 AM
This revision is now accepted and ready to land.Aug 16 2018, 10:31 AM
This revision was automatically updated to reflect the committed changes.