This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Address todo for handling 1/(2 pi)
ClosedPublic

Authored by arsenm on Aug 14 2018, 7:41 AM.

Details

Reviewers
rampitec

Diff Detail

Event Timeline

arsenm created this revision.Aug 14 2018, 7:41 AM
rampitec added inline comments.Aug 14 2018, 8:16 AM
lib/Target/AMDGPU/AMDGPUISelLowering.cpp
3457

You need to check bitwidth here. 0x3118 is a valid float 1.7612E-41. I assume same is true for double.

arsenm added inline comments.Aug 14 2018, 8:32 AM
lib/Target/AMDGPU/AMDGPUISelLowering.cpp
3457

.bitwiseIsEqual already checks the FP semantic type. This isn't a floating point compare

3457

The BitsToFloat shouldn't be used for half though

arsenm updated this revision to Diff 160610.Aug 14 2018, 9:20 AM

Don't use BitsTo*, add f16/f64 tests

This revision is now accepted and ready to land.Aug 14 2018, 11:52 PM
arsenm closed this revision.Aug 15 2018, 2:05 PM

r339814