This is an archive of the discontinued LLVM Phabricator instance.

[IslExprBuilder] Allow 64-bit ints in hasLargeInts()
Needs ReviewPublic

Authored by cs15btech11044 on Aug 13 2018, 9:44 AM.

Details

Summary

This patch allows for 64-bit integers to be not considered as a large int.

The bug came up because the invalid context was not evaluated properly during Chapel+Polly GSoC effort.

Diff Detail

Event Timeline

cs15btech11044 created this revision.Aug 13 2018, 9:44 AM

All the regression tests pass successfully.

Meinersbur added a comment.EditedAug 13 2018, 9:55 AM

To add some details: The original failure was external/skia/src/gpu/GrTestUtils.cpp of the aosp buildbot. It expects a library function __muloti4 which was lowered from the intrinsic llvm.smul.with.overflow.i128. The next smaller llvm.smul.with.overflow.i64 should be able to handle 64 bit values (not just 63 bits).