This is an archive of the discontinued LLVM Phabricator instance.

Differential D50425

The fix for c++11 flag issue was fixed in svn r339154 but for one Blur benchmark.
ClosedPublic

Authored by santosh on Aug 7 2018, 10:33 PM.

Details

Reviewers
Meinersbur
proton
Commits
rOLDT339228: Removed -std=c++11 flag from MicroBenchmarks/ImageProcessing/Blur/CMakeLists.txt
rL339228: Removed -std=c++11 flag from MicroBenchmarks/ImageProcessing/Blur/CMakeLists.txt
Summary

-std=c++11 flag was supposed to be in CXX_FLAGS but was used in CPP_FLAGS.

Diff Detail

Event Timeline

santosh created this revision.Aug 7 2018, 10:33 PM
Harbormaster completed remote builds in B21213: Diff 159643.Aug 7 2018, 10:33 PM
Herald added a subscriber: mgorny. · View Herald TranscriptAug 7 2018, 10:33 PM
Meinersbur edited reviewers, added: proton; removed: • proton0001.Aug 7 2018, 10:34 PM
proton accepted this revision.Aug 8 2018, 2:49 AM
This revision is now accepted and ready to land.Aug 8 2018, 2:49 AM
Closed by commit rL339228: Removed -std=c++11 flag from MicroBenchmarks/ImageProcessing/Blur/CMakeLists.txt (authored by proton). · Explain WhyAug 8 2018, 2:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
MicroBenchmarks/
ImageProcessing/
Blur/
2 lines

Diff 159643

MicroBenchmarks/ImageProcessing/Blur/CMakeLists.txt

set(IMAGEPROC_UTILS MicroBenchmarks/ImageProcessing/utils) set(IMAGEPROC_UTILS MicroBenchmarks/ImageProcessing/utils)
list(APPEND CPPFLAGS -I ${CMAKE_SOURCE_DIR}/${IMAGEPROC_UTILS} -std=c++11) list(APPEND CPPFLAGS -I ${CMAKE_SOURCE_DIR}/${IMAGEPROC_UTILS})
list(APPEND LDFLAGS -lm) list(APPEND LDFLAGS -lm)
llvm_test_verify("${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${CMAKE_CURRENT_BINARY_DIR}/boxBlurOutput.txt") llvm_test_verify("${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${CMAKE_CURRENT_BINARY_DIR}/boxBlurOutput.txt")
llvm_test_verify("${FPCMP} ${CMAKE_CURRENT_BINARY_DIR}/boxBlurOutput.txt ${CMAKE_CURRENT_SOURCE_DIR}/boxBlur.reference_output") llvm_test_verify("${FPCMP} ${CMAKE_CURRENT_BINARY_DIR}/boxBlurOutput.txt ${CMAKE_CURRENT_SOURCE_DIR}/boxBlur.reference_output")
llvm_test_verify("${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${CMAKE_CURRENT_BINARY_DIR}/gaussianBlurOutput.txt") llvm_test_verify("${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${CMAKE_CURRENT_BINARY_DIR}/gaussianBlurOutput.txt")
llvm_test_verify("${FPCMP} ${CMAKE_CURRENT_BINARY_DIR}/gaussianBlurOutput.txt ${CMAKE_CURRENT_SOURCE_DIR}/gaussianBlur.reference_output") llvm_test_verify("${FPCMP} ${CMAKE_CURRENT_BINARY_DIR}/gaussianBlurOutput.txt ${CMAKE_CURRENT_SOURCE_DIR}/gaussianBlur.reference_output")
llvm_test_run(WORKDIR ${CMAKE_CURRENT_BINARY_DIR}) llvm_test_run(WORKDIR ${CMAKE_CURRENT_BINARY_DIR})
llvm_test_executable(blur ../utils/ImageHelper.cpp ../utils/glibc_compat_rand.c main.cpp boxBlurKernel.c gaussianBlurKernel.c) llvm_test_executable(blur ../utils/ImageHelper.cpp ../utils/glibc_compat_rand.c main.cpp boxBlurKernel.c gaussianBlurKernel.c)
target_link_libraries(blur benchmark) target_link_libraries(blur benchmark)