New ImageProcessing tests were failing becuase c++ flags are used in c flags.

[santosh]

Summary

clang was invoked on .c files. CPPFLAGS were used in clang which has -std=c++11, a c++ flag,, which is not supported.

[santosh]

Just added test Microbenchmark test Interpolation has the same issue.

[Meinersbur]

Thank you. LGTM.

[Meinersbur]

@santosh Do you need someone to commit?

[santosh]

In D50379#1190907, @Meinersbur wrote:

@santosh Do you need someone to commit?

Yes. Thanks.

[Meinersbur]

Seems that @proton already fixed this as part of rL339154. Closing this review. In any case, I want to thank you for opening it!

[proton]

Thank you for the solution Santosh, It seems like my GitHub account was actually linked to some other account on Phabricator which I was not aware of, so I didn't get any notification for this patch on this account. I will try to get that account removed so that this won't happen in future.

MicroBenchmarks/ImageProcessing/AnisotropicDiffusion/CMakeLists.txt

 set(IMAGEPROC_UTILS MicroBenchmarks/ImageProcessing/utils)
 
-list(APPEND CPPFLAGS -I ${CMAKE_SOURCE_DIR}/${IMAGEPROC_UTILS} -std=c++11)
+list(APPEND CPPFLAGS -I ${CMAKE_SOURCE_DIR}/${IMAGEPROC_UTILS})
+list(APPEND CXX_FLAGS -std=c++11)
 
 llvm_test_verify("${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${CMAKE_CURRENT_BINARY_DIR}/anisotropicDiffusionOutput.txt")
 llvm_test_verify("${FPCMP} ${CMAKE_CURRENT_BINARY_DIR}/anisotropicDiffusionOutput.txt ${CMAKE_CURRENT_SOURCE_DIR}/anisotropicDiffusion.reference_output")
 
 llvm_test_run(WORKDIR ${CMAKE_CURRENT_BINARY_DIR})
 
 llvm_test_executable(AnisotropicDiffusion ../utils/ImageHelper.cpp ../utils/glibc_compat_rand.c main.cpp anisotropicDiffusionKernel.c)
 
 target_link_libraries(AnisotropicDiffusion benchmark)

MicroBenchmarks/ImageProcessing/Blur/CMakeLists.txt

 set(IMAGEPROC_UTILS MicroBenchmarks/ImageProcessing/utils)
 
-list(APPEND CPPFLAGS -I ${CMAKE_SOURCE_DIR}/${IMAGEPROC_UTILS} -std=c++11)
+list(APPEND CPPFLAGS -I ${CMAKE_SOURCE_DIR}/${IMAGEPROC_UTILS})
+list(APPEND CXX_FLAGS -std=c++11)
 
 llvm_test_verify("${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${CMAKE_CURRENT_BINARY_DIR}/boxBlurOutput.txt")
 llvm_test_verify("${FPCMP} ${CMAKE_CURRENT_BINARY_DIR}/boxBlurOutput.txt ${CMAKE_CURRENT_SOURCE_DIR}/boxBlur.reference_output")
 
 llvm_test_verify("${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${CMAKE_CURRENT_BINARY_DIR}/gaussianBlurOutput.txt")
 llvm_test_verify("${FPCMP} ${CMAKE_CURRENT_BINARY_DIR}/gaussianBlurOutput.txt ${CMAKE_CURRENT_SOURCE_DIR}/gaussianBlur.reference_output")
 
 llvm_test_run(WORKDIR ${CMAKE_CURRENT_BINARY_DIR})
 
 llvm_test_executable(blur ../utils/ImageHelper.cpp ../utils/glibc_compat_rand.c main.cpp boxBlurKernel.c gaussianBlurKernel.c)
 
 target_link_libraries(blur benchmark)

MicroBenchmarks/ImageProcessing/Dither/CMakeLists.txt

 set(IMAGEPROC_UTILS MicroBenchmarks/ImageProcessing/utils)
-list(APPEND CPPFLAGS -I ${CMAKE_SOURCE_DIR}/${IMAGEPROC_UTILS} -std=c++11)
+list(APPEND CPPFLAGS -I ${CMAKE_SOURCE_DIR}/${IMAGEPROC_UTILS})
+list(APPEND CXX_FLAGS -std=c++11)
 
 llvm_test_verify("${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${CMAKE_CURRENT_BINARY_DIR}/orderedOutput.txt")
 llvm_test_verify("${FPCMP} ${CMAKE_CURRENT_BINARY_DIR}/orderedOutput.txt ${CMAKE_CURRENT_SOURCE_DIR}/orderedDither.reference_output")
 
 llvm_test_verify("${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${CMAKE_CURRENT_BINARY_DIR}/floydOutput.txt")
 llvm_test_verify("${FPCMP} ${CMAKE_CURRENT_BINARY_DIR}/floydOutput.txt ${CMAKE_CURRENT_SOURCE_DIR}/floydDither.reference_output")
 
 llvm_test_run(WORKDIR ${CMAKE_CURRENT_BINARY_DIR})
 llvm_test_executable(Dither main.cpp orderedDitherKernel.c  floydDitherKernel.c ../utils/ImageHelper.cpp ../utils/glibc_compat_rand.c)
 
 target_link_libraries(Dither benchmark)

MicroBenchmarks/ImageProcessing/Interpolation/CMakeLists.txt

 set(IMAGEPROC_UTILS MicroBenchmarks/ImageProcessing/utils)
-list(APPEND CPPFLAGS -I ${CMAKE_SOURCE_DIR}/${IMAGEPROC_UTILS} -std=c++11)
+list(APPEND CPPFLAGS -I ${CMAKE_SOURCE_DIR}/${IMAGEPROC_UTILS})
+list(APPEND CXX_FLAGS -std=c++11)
 
 llvm_test_verify("${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${CMAKE_CURRENT_BINARY_DIR}/bicubicOutput.txt")
 llvm_test_verify("${FPCMP} ${CMAKE_CURRENT_BINARY_DIR}/bicubicOutput.txt ${CMAKE_CURRENT_SOURCE_DIR}/bicubic.reference_output")
 
 llvm_test_verify("${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${CMAKE_CURRENT_BINARY_DIR}/bilinearOutput.txt")
 llvm_test_verify("${FPCMP} ${CMAKE_CURRENT_BINARY_DIR}/bilinearOutput.txt ${CMAKE_CURRENT_SOURCE_DIR}/bilinear.reference_output")
 
 llvm_test_run(WORKDIR ${CMAKE_CURRENT_BINARY_DIR})
 llvm_test_executable(Interpolation bicubicKernel.c bilinearKernel.c main.cpp ../utils/ImageHelper.cpp ../utils/glibc_compat_rand.c)
 
 target_link_libraries(Interpolation benchmark)