This is an archive of the discontinued LLVM Phabricator instance.

[lit, tests] Fix failing lit test: shtest-format.py
ClosedPublic

Authored by stella.stamenova on Aug 6 2018, 9:06 PM.

Details

Summary

The problem here is that on windows double quotes are used for paths (usually) while single quotes are not. This is not generally a problem for the tests because the lit infrastructure tends to treat both the same. One (and possibly only) exception is when some tests are run in an external shell such as some of the shtest-format tests. In this case on windows the path to python was not created correctly because it had single quotes and the test failed.

This same test is already failing with python 3 which is why our testing missed the new failure. This patch will take care of the immediate failure with python 2 and I'll send a follow up for the python 3 failure.

Diff Detail

Repository
rL LLVM

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 6 2018, 9:09 PM
This revision was automatically updated to reflect the committed changes.