This is an archive of the discontinued LLVM Phabricator instance.

[LLD] [COFF] Fix a comment about automatic resolving of dllimports from within a module. NFC.
ClosedPublic

Authored by mstorsjo on Aug 6 2018, 12:57 PM.

Reviewers

Commits

LGTM

This revision is now accepted and ready to land.Aug 6 2018, 2:57 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

COFF/

4 lines

Show First 20 Lines • Show All 325 Lines • ▼ Show 20 Lines	public:
Chunk *getChunk() { return Data; }		Chunk *getChunk() { return Data; }

DefinedImportData *WrappedSym;		DefinedImportData *WrappedSym;

private:		private:
Chunk *Data;		Chunk *Data;
};		};

// If you have a symbol "__imp_foo" in your object file, a symbol name		// If you have a symbol "foo" in your object file, a symbol name
// "foo" becomes automatically available as a pointer to "__imp_foo".		// "__imp_foo" becomes automatically available as a pointer to "foo".
// This class is for such automatically-created symbols.		// This class is for such automatically-created symbols.
// Yes, this is an odd feature. We didn't intend to implement that.		// Yes, this is an odd feature. We didn't intend to implement that.
// This is here just for compatibility with MSVC.		// This is here just for compatibility with MSVC.
class DefinedLocalImport : public Defined {		class DefinedLocalImport : public Defined {
public:		public:
DefinedLocalImport(StringRef N, Defined *S)		DefinedLocalImport(StringRef N, Defined *S)
: Defined(DefinedLocalImportKind, N), Data(make<LocalImportChunk>(S)) {}		: Defined(DefinedLocalImportKind, N), Data(make<LocalImportChunk>(S)) {}

▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines