This is an archive of the discontinued LLVM Phabricator instance.

Differential D50244

[libunwind][mips] Guard accumulator registers
ClosedPublic

Authored by smaksimovic on Aug 3 2018, 5:15 AM.

Details

Reviewers
atanasyan
Commits
rGfe50950dac3a: [libunwind][mips] Guard accumulator registers
rUNW339849: [libunwind][mips] Guard accumulator registers
rL339849: [libunwind][mips] Guard accumulator registers
Summary

Mipsr6 does not possess HI and LO accumulator registers, adjust validRegister functions to respect that.

Diff Detail

Event Timeline

smaksimovic created this revision.Aug 3 2018, 5:15 AM
Herald added subscribers: chrib, arichardson, sdardis. · View Herald TranscriptAug 3 2018, 5:15 AM
atanasyan accepted this revision.Aug 3 2018, 4:16 PM

LGTM

This revision is now accepted and ready to land.Aug 3 2018, 4:16 PM
Closed by commit rL339849: [libunwind][mips] Guard accumulator registers (authored by smaksimovic). · Explain WhyAug 16 2018, 1:50 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: christof. · View Herald TranscriptAug 16 2018, 1:50 AM

Revision Contents

PathSize
src/
4 lines

Diff 158983

src/Registers.hpp

Show First 20 Lines • Show All 2,753 Lines • ▼ Show 20 Linesinline bool Registers_mips_o32::validRegister(int regNum) const {
if (regNum == UNW_REG_IP) if (regNum == UNW_REG_IP)
return true; return true;
if (regNum == UNW_REG_SP) if (regNum == UNW_REG_SP)
return true; return true;
if (regNum < 0) if (regNum < 0)
return false; return false;
if (regNum <= UNW_MIPS_R31) if (regNum <= UNW_MIPS_R31)
return true; return true;
#if __mips_isa_rev != 6
if (regNum == UNW_MIPS_HI) if (regNum == UNW_MIPS_HI)
return true; return true;
if (regNum == UNW_MIPS_LO) if (regNum == UNW_MIPS_LO)
return true; return true;
#endif
#if defined(__mips_hard_float) && __mips_fpr == 32 #if defined(__mips_hard_float) && __mips_fpr == 32
if (regNum >= UNW_MIPS_F0 && regNum <= UNW_MIPS_F31) if (regNum >= UNW_MIPS_F0 && regNum <= UNW_MIPS_F31)
return true; return true;
#endif #endif
// FIXME: DSP accumulator registers, MSA registers // FIXME: DSP accumulator registers, MSA registers
return false; return false;
} }
▲ Show 20 Lines • Show All 294 Lines • ▼ Show 20 Linesinline bool Registers_mips_newabi::validRegister(int regNum) const {
if (regNum == UNW_REG_IP) if (regNum == UNW_REG_IP)
return true; return true;
if (regNum == UNW_REG_SP) if (regNum == UNW_REG_SP)
return true; return true;
if (regNum < 0) if (regNum < 0)
return false; return false;
if (regNum <= UNW_MIPS_R31) if (regNum <= UNW_MIPS_R31)
return true; return true;
#if __mips_isa_rev != 6
if (regNum == UNW_MIPS_HI) if (regNum == UNW_MIPS_HI)
return true; return true;
if (regNum == UNW_MIPS_LO) if (regNum == UNW_MIPS_LO)
return true; return true;
#endif
// FIXME: Hard float, DSP accumulator registers, MSA registers // FIXME: Hard float, DSP accumulator registers, MSA registers
return false; return false;
} }
inline uint64_t Registers_mips_newabi::getRegister(int regNum) const { inline uint64_t Registers_mips_newabi::getRegister(int regNum) const {
if (regNum >= UNW_MIPS_R0 && regNum <= UNW_MIPS_R31) if (regNum >= UNW_MIPS_R0 && regNum <= UNW_MIPS_R31)
return _registers.__r[regNum - UNW_MIPS_R0]; return _registers.__r[regNum - UNW_MIPS_R0];
▲ Show 20 Lines • Show All 217 Lines • Show Last 20 Lines